Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1649423002: PRESUBMIT: Exclude supplement.gypi from _CheckNoSourcesAboveGyp check. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

PRESUBMIT: Exclude supplement.gypi from _CheckNoSourcesAboveGyp check. The webrtc/supplement.gypi contains a source listing of the suppressions for TSan and LSan, which are located in source files. It makes the presubmit fail when it's updated, which is confusing. NOTRY=True TESTED=Edited webrtc/supplement.gypi and ran "git cl presubmit" without an error. Committed: https://crrev.com/c61635c2db30ee5daa43eeb49362468756efa10c Cr-Commit-Position: refs/heads/master@{#11457}

Patch Set 1 : #

Patch Set 2 : Simplify check to avoid potential problems on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M PRESUBMIT.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-01 12:37:30 UTC) #5
tkchin_webrtc
On 2016/02/01 12:37:30, kjellander (webrtc) wrote: lgtm
4 years, 10 months ago (2016-02-02 09:38:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649423002/40001
4 years, 10 months ago (2016-02-02 10:27:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-02 10:30:16 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 10:31:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c61635c2db30ee5daa43eeb49362468756efa10c
Cr-Commit-Position: refs/heads/master@{#11457}

Powered by Google App Engine
This is Rietveld 408576698