Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: PRESUBMIT.py

Issue 1649423002: PRESUBMIT: Exclude supplement.gypi from _CheckNoSourcesAboveGyp check. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Simplify check to avoid potential problems on Windows Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3fb3ed170e5248323ad1fde58db1fb0cc3aba4ec..ce175a4d4295a1f3e99237a4135ee96e2f53b053 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -235,6 +235,10 @@ def _CheckNoSourcesAboveGyp(input_api, gyp_files, output_api):
violating_gyp_files = set()
violating_source_entries = []
for gyp_file in gyp_files:
+ if 'supplement.gypi' in gyp_file.LocalPath():
+ # Exclude supplement.gypi from this check, as the LSan and TSan
+ # suppression files are located in a different location.
+ continue
contents = input_api.ReadFile(gyp_file)
for source_block_match in source_pattern.finditer(contents):
# Find all source list entries starting with ../ in the source block
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698