Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1646463002: Revert of New rtc::VideoSinkInterface. (Closed)

Created:
4 years, 11 months ago by nisse-webrtc
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of New rtc::VideoSinkInterface. (patchset #7 id:120001 of https://codereview.webrtc.org/1594973006/ ) Reason for revert: Broke chrome build. Investigating. First error relating to AddSink method in mock_peer_connection_dependency_factory.h Original issue's description: > New rtc::VideoSinkInterface. > > The plan is that this interface should be used by all classes which receive a stream of video frames, and replace the two generic classes webrtc::VideoRendererInterface and cricket::VideoRenderer. > > And the list goes on, there's a dozen of different classes which act as video frame sinks. > > At some point, we will likely add some method to handle sink properties like, e.g, maximum useful width and height. But hopefully this can be done while keeping the interface very simple. > > BUG=webrtc:5426 > R=perkj@webrtc.org, pthatcher@webrtc.org > > Committed: https://crrev.com/a862d4563fbc26e52bed442de784094ae1dfe5ee > Cr-Commit-Position: refs/heads/master@{#11396} TBR=pthatcher@webrtc.org,pbos@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5426 Committed: https://crrev.com/2098fca39a2ebc22d6fc4a9db329668e6b31f6cb Cr-Commit-Position: refs/heads/master@{#11397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -162 lines) Patch
M talk/app/webrtc/mediastreaminterface.h View 2 chunks +1 line, -7 lines 0 comments Download
M talk/app/webrtc/rtpsenderreceiver_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M talk/app/webrtc/videosource.h View 3 chunks +3 lines, -4 lines 0 comments Download
M talk/app/webrtc/videosource.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M talk/app/webrtc/videosourceinterface.h View 1 chunk +2 lines, -4 lines 0 comments Download
M talk/app/webrtc/videosourceproxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/media/base/capturemanager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M talk/media/base/capturemanager.cc View 2 chunks +21 lines, -20 lines 0 comments Download
M talk/media/base/capturemanager_unittest.cc View 7 chunks +17 lines, -7 lines 0 comments Download
M talk/media/base/capturerenderadapter.h View 2 chunks +7 lines, -5 lines 0 comments Download
M talk/media/base/capturerenderadapter.cc View 3 chunks +21 lines, -12 lines 0 comments Download
M talk/media/base/fakecapturemanager.h View 1 chunk +8 lines, -4 lines 0 comments Download
M talk/media/base/videorenderer.h View 1 chunk +1 line, -8 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.h View 3 chunks +8 lines, -9 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M talk/session/media/channelmanager.h View 1 chunk +2 lines, -4 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 chunk +12 lines, -14 lines 0 comments Download
D webrtc/media/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/media/base/videosinkinterface.h View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nisse-webrtc
Created Revert of New rtc::VideoSinkInterface.
4 years, 11 months ago (2016-01-27 14:12:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646463002/1
4 years, 11 months ago (2016-01-27 14:12:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 14:12:54 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 14:13:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2098fca39a2ebc22d6fc4a9db329668e6b31f6cb
Cr-Commit-Position: refs/heads/master@{#11397}

Powered by Google App Engine
This is Rietveld 408576698