Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: talk/media/base/capturemanager.cc

Issue 1646463002: Revert of New rtc::VideoSinkInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/capturemanager.h ('k') | talk/media/base/capturemanager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/base/capturemanager.cc
diff --git a/talk/media/base/capturemanager.cc b/talk/media/base/capturemanager.cc
index 78ca99d39c80635cdade7d92ed57d82b7f51a62e..dab33fd2bc73d4996cbb93c8e5e0eaa30f48b461 100644
--- a/talk/media/base/capturemanager.cc
+++ b/talk/media/base/capturemanager.cc
@@ -30,6 +30,7 @@
#include <algorithm>
#include "talk/media/base/videocapturer.h"
+#include "talk/media/base/videorenderer.h"
#include "webrtc/base/checks.h"
#include "webrtc/base/logging.h"
@@ -286,32 +287,32 @@
return true;
}
-void CaptureManager::AddVideoSink(VideoCapturer* video_capturer,
- rtc::VideoSinkInterface<VideoFrame>* sink) {
- RTC_DCHECK(thread_checker_.CalledOnValidThread());
- // TODO(nisse): Do we really need to tolerate NULL inputs?
- if (!video_capturer || !sink) {
- return;
+bool CaptureManager::AddVideoRenderer(VideoCapturer* video_capturer,
+ VideoRenderer* video_renderer) {
+ RTC_DCHECK(thread_checker_.CalledOnValidThread());
+ if (!video_capturer || !video_renderer) {
+ return false;
}
CaptureRenderAdapter* adapter = GetAdapter(video_capturer);
if (!adapter) {
- return;
- }
- adapter->AddSink(sink);
-}
-
-void CaptureManager::RemoveVideoSink(
- VideoCapturer* video_capturer,
- rtc::VideoSinkInterface<VideoFrame>* sink) {
- RTC_DCHECK(thread_checker_.CalledOnValidThread());
- if (!video_capturer || !sink) {
- return;
+ return false;
+ }
+ adapter->AddRenderer(video_renderer);
+ return true;
+}
+
+bool CaptureManager::RemoveVideoRenderer(VideoCapturer* video_capturer,
+ VideoRenderer* video_renderer) {
+ RTC_DCHECK(thread_checker_.CalledOnValidThread());
+ if (!video_capturer || !video_renderer) {
+ return false;
}
CaptureRenderAdapter* adapter = GetAdapter(video_capturer);
if (!adapter) {
- return;
- }
- adapter->RemoveSink(sink);
+ return false;
+ }
+ adapter->RemoveRenderer(video_renderer);
+ return true;
}
bool CaptureManager::IsCapturerRegistered(VideoCapturer* video_capturer) const {
« no previous file with comments | « talk/media/base/capturemanager.h ('k') | talk/media/base/capturemanager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698