Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: webrtc/base/logging.cc

Issue 1644843003: Compile rtc_base_objc and rtc_api_objc for Mac (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/logging.cc
diff --git a/webrtc/base/logging.cc b/webrtc/base/logging.cc
index 686b9b2b02b482e104f7daab6eb5f4bde336821d..3407f146d002637fb0fb0ef01150cbab8c948d83 100644
--- a/webrtc/base/logging.cc
+++ b/webrtc/base/logging.cc
@@ -169,10 +169,13 @@ LogMessage::LogMessage(const char* file,
#endif // WEBRTC_WIN
#if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS)
case ERRCTX_OSSTATUS: {
+ #pragma clang diagnostic push
tkchin_webrtc 2016/01/28 21:09:44 compiler directives have no indentation Can you fi
hjon_webrtc 2016/01/28 23:49:51 Fixed indentation. Is there a preferred way to ref
tkchin_webrtc 2016/01/29 00:26:29 I'm not against pasting links if it fits in 80. //
+ #pragma clang diagnostic ignored "-Wdeprecated"
tmp << " " << nonnull(GetMacOSStatusErrorString(err), "Unknown error");
if (const char* desc = GetMacOSStatusCommentString(err)) {
tmp << ": " << desc;
}
+ #pragma clang diagnostic pop
break;
}
#endif // WEBRTC_MAC && !defined(WEBRTC_IOS)

Powered by Google App Engine
This is Rietveld 408576698