Compile rtc_base_objc and rtc_api_objc for Mac

webrtc/base/logging.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 151 matching lines @@
               isspace(static_cast<unsigned char>(msgbuf[len-1]))) {
             msgbuf[--len] = 0;
           }
           tmp << " " << msgbuf;
         }
         break;
       }
 #endif  // WEBRTC_WIN
 #if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS)
       case ERRCTX_OSSTATUS: {
+        #pragma clang diagnostic push

[tkchin_webrtc, 2016/01/28 21:09:44]

compiler directives have no indentation
Can you file a bug and reference it? Here and rest of CL.

Bug should be: Replace deprecated OS/X system calls.
And then add that there aren't actually good replacements.
You can file it on tommi@ for now and cc me. 

[hjon_webrtc, 2016/01/28 23:49:51]

Fixed indentation. Is there a preferred way to reference bugs? I think I've seen
things like http://crbug.com/<bugNumber>. Is there anything like that for
WebRTC?

[tkchin_webrtc, 2016/01/29 00:26:29]

I'm not against pasting links if it fits in 80.
// TODO(hjon): Update deprecated APIs.
// See <url>
should be fine.

Or if you don't want your name attached to it... :)
// TODO(bug#): Fix deprecated APIs.

+        #pragma clang diagnostic ignored "-Wdeprecated"
         tmp << " " << nonnull(GetMacOSStatusErrorString(err), "Unknown error");
         if (const char* desc = GetMacOSStatusCommentString(err)) {
           tmp << ": " << desc;
         }
+        #pragma clang diagnostic pop
         break;
       }
 #endif  // WEBRTC_MAC && !defined(WEBRTC_IOS)
       default:
         break;
     }
     extra_ = tmp.str();
   }
 }
 
@@ skipping 361 matching lines @@
   }
 
   if (state) {
     state->unprintable_count_[input] = consecutive_unprintable;
   }
 }
 
 //////////////////////////////////////////////////////////////////////
 
 }  // namespace rtc