Replace const-reference with pointer in SendData.

Replace const-reference with pointer in SendData.

This argument is never used as a reference and the pointer that's bound
to the const reference may be nullptr. This is undefined behavior and
barks under UBSan.

BUG=webrtc:5124
R=stefan@webrtc.org

Committed: https://crrev.com/fb152707ed224cc9e51850a698ca739f9a76aff1
Cr-Commit-Position: refs/heads/master@{#11418}

[pbos-webrtc, 2016-01-28 13:47:19]

PTAL

[pbos-webrtc, 2016-01-28 13:47:43]

Example failure:

Note: Google Test filter = EndToEndTest.CanReceiveFec
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from EndToEndTest
[ RUN      ] EndToEndTest.CanReceiveFec
(systeminfo.cc:82): Available number of cores: 4
(remote_bitrate_estimator_single_stream.cc:59):
RemoteBitrateEstimatorSingleStream: Instantiating.
(remote_bitrate_estimator_single_stream.cc:59):
RemoteBitrateEstimatorSingleStream: Instantiating.
(video_send_stream.cc:132): VideoSendStream: {encoder_settings: {payload_name:
FAKE, payload_type: 125, encoder: (VideoEncoder)}, rtp: {ssrcs: [12648429],
max_packet_size: 1460, extensions: [{name:
http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time, id: 7}, {name:
urn:3gpp:video-orientation, id: 4}], nack: {rtp_history_ms: 0}, fec:
{ulpfec_payload_type: 119, red_payload_type: 118}, rtx: {ssrcs: [],
payload_type: -1}, c_name: }, pre_encode_callback: nullptr,
post_encode_callback: nullptr, local_renderer: nullptr, render_delay_ms: 0,
target_delay_ms: 0, suspend_below_min_bitrate: off}
(video_send_stream.cc:300): (Re)configureVideoEncoder: {streams: [{width: 320,
height: 180, max_framerate: 30, min_bitrate_bps:50000,
target_bitrate_bps:150000, max_bitrate_bps:150000, max_qp: 56,
temporal_layer_thresholds_bps: []}], content_type: kRealtimeVideo,
encoder_specific_settings: NULL, min_transmit_bitrate_bps: 0}
(video_receive_stream.cc:154): VideoReceiveStream: {decoders: [{decoder:
(VideoDecoder), payload_type: 125, payload_name: FAKE}], rtp: {remote_ssrc:
12648429, local_ssrc: 1193046, rtcp_mode: RtcpMode::kCompound, rtcp_xr:
{receiver_reference_time_report: off}, remb: on, transport_cc: off, nack:
{rtp_history_ms: 0}, fec: {ulpfec_payload_type: 119, red_payload_type: 118},
rtx: {}, extensions: [{name:
http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time, id: 7}, {name:
urn:3gpp:video-orientation, id: 4}]}, renderer: (renderer), render_delay_ms: 10,
pre_decode_callback: nullptr, pre_render_callback: nullptr, target_delay_ms: 0}
../../webrtc/modules/video_coding/generic_encoder.cc:288:36: runtime error:
reference binding to null pointer of type 'const webrtc::RTPFragmentationHeader'
[62/232] EndToEndTest.CanReceiveFec returned/aborted with exit code 1 (39 ms)

[stefan-webrtc, 2016-01-28 16:48:24]

lgtm

[pbos-webrtc, 2016-01-28 18:12:14]

Description was changed from

==========
Replace const-reference with pointer in SendData.

This argument is never used as a reference and the pointer that's bound
to the const reference may be nullptr. This is undefined behavior and
barks under UBSan.

BUG=webrtc:5124
R=stefan@webrtc.org
==========

to

==========
Replace const-reference with pointer in SendData.

This argument is never used as a reference and the pointer that's bound
to the const reference may be nullptr. This is undefined behavior and
barks under UBSan.

BUG=webrtc:5124
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fb152707ed224cc9e51850a69...
==========

[pbos-webrtc, 2016-01-28 18:12:15]

Committed patchset #1 (id:1) manually as
fb152707ed224cc9e51850a698ca739f9a76aff1 (presubmit successful).

[commit-bot: I haz the power, 2016-01-28 18:12:17]

Description was changed from

==========
Replace const-reference with pointer in SendData.

This argument is never used as a reference and the pointer that's bound
to the const reference may be nullptr. This is undefined behavior and
barks under UBSan.

BUG=webrtc:5124
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fb152707ed224cc9e51850a69...
==========

to

==========
Replace const-reference with pointer in SendData.

This argument is never used as a reference and the pointer that's bound
to the const reference may be nullptr. This is undefined behavior and
barks under UBSan.

BUG=webrtc:5124
R=stefan@webrtc.org

Committed: https://crrev.com/fb152707ed224cc9e51850a698ca739f9a76aff1
Cr-Commit-Position: refs/heads/master@{#11418}
==========

[commit-bot: I haz the power, 2016-01-28 18:12:18]

Patchset 1 (id:??) landed as
https://crrev.com/fb152707ed224cc9e51850a698ca739f9a76aff1
Cr-Commit-Position: refs/heads/master@{#11418}