Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: webrtc/modules/video_coding/video_sender_unittest.cc

Issue 1642863003: Replace const-reference with pointer in SendData. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/include/video_coding_defines.h ('k') | webrtc/video/vie_encoder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 class PacketizationCallback : public VCMPacketizationCallback { 89 class PacketizationCallback : public VCMPacketizationCallback {
90 public: 90 public:
91 explicit PacketizationCallback(Clock* clock) 91 explicit PacketizationCallback(Clock* clock)
92 : clock_(clock), start_time_ms_(clock_->TimeInMilliseconds()) {} 92 : clock_(clock), start_time_ms_(clock_->TimeInMilliseconds()) {}
93 93
94 virtual ~PacketizationCallback() {} 94 virtual ~PacketizationCallback() {}
95 95
96 int32_t SendData(uint8_t payload_type, 96 int32_t SendData(uint8_t payload_type,
97 const EncodedImage& encoded_image, 97 const EncodedImage& encoded_image,
98 const RTPFragmentationHeader& fragmentation_header, 98 const RTPFragmentationHeader* fragmentation_header,
99 const RTPVideoHeader* rtp_video_header) override { 99 const RTPVideoHeader* rtp_video_header) override {
100 assert(rtp_video_header); 100 assert(rtp_video_header);
101 frame_data_.push_back(FrameData(encoded_image._length, *rtp_video_header)); 101 frame_data_.push_back(FrameData(encoded_image._length, *rtp_video_header));
102 return 0; 102 return 0;
103 } 103 }
104 104
105 void Reset() { 105 void Reset() {
106 frame_data_.clear(); 106 frame_data_.clear();
107 start_time_ms_ = clock_->TimeInMilliseconds(); 107 start_time_ms_ = clock_->TimeInMilliseconds();
108 } 108 }
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 } 490 }
491 { 491 {
492 // TODO(andresp): Find out why this fails with framerate = 7.5 492 // TODO(andresp): Find out why this fails with framerate = 7.5
493 Vp8StreamInfo expected = {{7.0, 7.0, 7.0}, {high_b, high_b, high_b}}; 493 Vp8StreamInfo expected = {{7.0, 7.0, 7.0}, {high_b, high_b, high_b}};
494 EXPECT_THAT(SimulateWithFramerate(7.0), MatchesVp8StreamInfo(expected)); 494 EXPECT_THAT(SimulateWithFramerate(7.0), MatchesVp8StreamInfo(expected));
495 } 495 }
496 } 496 }
497 } // namespace 497 } // namespace
498 } // namespace vcm 498 } // namespace vcm
499 } // namespace webrtc 499 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/include/video_coding_defines.h ('k') | webrtc/video/vie_encoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698