Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1638283003: Add shouldDisableBuffering to RTCFileLogger. (Closed)

Created:
4 years, 11 months ago by tkchin_webrtc
Modified:
4 years, 11 months ago
Reviewers:
hjon_webrtc, Chuck
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add shouldDisableBuffering to RTCFileLogger. Expose disableBuffering method on underlying log sink. This will make every write to the stream immediately write to the disk. Useful in crash situations so that buffered output is not lost. BUG= Committed: https://crrev.com/d162a5e379759a492661f5cf823c3e629e684930 Cr-Commit-Position: refs/heads/master@{#11407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M talk/app/webrtc/objc/RTCFileLogger.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCFileLogger.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tkchin_webrtc
4 years, 11 months ago (2016-01-27 19:38:17 UTC) #3
hjon_webrtc
lgtm
4 years, 11 months ago (2016-01-27 20:58:06 UTC) #4
Chuck
lgtm Could you add something to the description that says why this is needed so ...
4 years, 11 months ago (2016-01-27 22:02:36 UTC) #5
tkchin_webrtc
Done. Thanks.
4 years, 11 months ago (2016-01-27 22:52:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638283003/1
4 years, 11 months ago (2016-01-27 22:52:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 23:11:50 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 23:12:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d162a5e379759a492661f5cf823c3e629e684930
Cr-Commit-Position: refs/heads/master@{#11407}

Powered by Google App Engine
This is Rietveld 408576698