Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: talk/app/webrtc/objc/public/RTCFileLogger.h

Issue 1638283003: Add shouldDisableBuffering to RTCFileLogger. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/objc/RTCFileLogger.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 // This class is not threadsafe. 53 // This class is not threadsafe.
54 @interface RTCFileLogger : NSObject 54 @interface RTCFileLogger : NSObject
55 55
56 // The severity level to capture. The default is kRTCFileLoggerSeverityInfo. 56 // The severity level to capture. The default is kRTCFileLoggerSeverityInfo.
57 @property(nonatomic, assign) RTCFileLoggerSeverity severity; 57 @property(nonatomic, assign) RTCFileLoggerSeverity severity;
58 58
59 // The rotation type for this file logger. The default is 59 // The rotation type for this file logger. The default is
60 // kRTCFileLoggerTypeCall. 60 // kRTCFileLoggerTypeCall.
61 @property(nonatomic, readonly) RTCFileLoggerRotationType rotationType; 61 @property(nonatomic, readonly) RTCFileLoggerRotationType rotationType;
62 62
63 // Disables buffering disk writes. Should be set before |start|. Buffering
64 // is enabled by default for performance.
65 @property(nonatomic, assign) BOOL shouldDisableBuffering;
66
63 // Default constructor provides default settings for dir path, file size and 67 // Default constructor provides default settings for dir path, file size and
64 // rotation type. 68 // rotation type.
65 - (instancetype)init; 69 - (instancetype)init;
66 70
67 // Create file logger with default rotation type. 71 // Create file logger with default rotation type.
68 - (instancetype)initWithDirPath:(NSString *)dirPath 72 - (instancetype)initWithDirPath:(NSString *)dirPath
69 maxFileSize:(NSUInteger)maxFileSize; 73 maxFileSize:(NSUInteger)maxFileSize;
70 74
71 - (instancetype)initWithDirPath:(NSString *)dirPath 75 - (instancetype)initWithDirPath:(NSString *)dirPath
72 maxFileSize:(NSUInteger)maxFileSize 76 maxFileSize:(NSUInteger)maxFileSize
73 rotationType:(RTCFileLoggerRotationType)rotationType 77 rotationType:(RTCFileLoggerRotationType)rotationType
74 NS_DESIGNATED_INITIALIZER; 78 NS_DESIGNATED_INITIALIZER;
75 79
76 // Starts writing WebRTC logs to disk if not already started. Overwrites any 80 // Starts writing WebRTC logs to disk if not already started. Overwrites any
77 // existing file(s). 81 // existing file(s).
78 - (void)start; 82 - (void)start;
79 83
80 // Stops writing WebRTC logs to disk. This method is also called on dealloc. 84 // Stops writing WebRTC logs to disk. This method is also called on dealloc.
81 - (void)stop; 85 - (void)stop;
82 86
83 // Returns the current contents of the logs, or nil if start has been called 87 // Returns the current contents of the logs, or nil if start has been called
84 // without a stop. 88 // without a stop.
85 - (NSData *)logData; 89 - (NSData *)logData;
86 90
87 @end 91 @end
OLDNEW
« no previous file with comments | « talk/app/webrtc/objc/RTCFileLogger.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698