Dont cache activity for external navigation handling

Dont cache activity for external navigation handling

This removes the cached activity copies from InterceptNavigationHandler
and ExternalNavigationHandler.

- Uses application context when it doesn't make any difference(For
  package manager related calls.)
- Tries to get the activity through the tab and if not fail gracefully
  either by early return or using application context for launching new
  activity.

BUG=546736
Committed: https://crrev.com/d02c46df9dfd465461d14586f08745f7213c67f1
Cr-Commit-Position: refs/heads/master@{#371853}

[Yusuf, 2016-01-25 22:16:10]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2016-01-25 23:42:43]

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:62:
// At the point of creation the tab should have a valid WindowAndroid.
Add an assert?

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:67:
* @return The activity {@link Context} if it can be reached.
nit: Explicitly specify when you'd need this function.  Rename it; saying
IfAvailable implies that it'd return null.

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:275:
return ((Activity) context).startActivityIfNeeded(intent, -1);
if (context instanceof Activity) {
    return ((Activity) context).startActivityIfNeeded(intent, -1);
} else {
    return false;
}

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:286:
if (!(context instanceof Activity)) return;
nit newline

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:444:
if (!(context instanceof ChromeActivity)) return;
if (context instanceof ChromeActivity) {
    ((ChromeActivity) context).getTabModelSelector().closeTab(tab);
}

[Yusuf, 2016-01-25 23:55:59]

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:62:
// At the point of creation the tab should have a valid WindowAndroid.
On 2016/01/25 23:42:43, dfalcantara wrote:
> Add an assert?

Done.

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:67:
* @return The activity {@link Context} if it can be reached.
On 2016/01/25 23:42:43, dfalcantara wrote:
> nit: Explicitly specify when you'd need this function.  Rename it; saying
> IfAvailable implies that it'd return null.

Done.

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:275:
return ((Activity) context).startActivityIfNeeded(intent, -1);
On 2016/01/25 23:42:43, dfalcantara wrote:
> if (context instanceof Activity) {
>     return ((Activity) context).startActivityIfNeeded(intent, -1);
> } else {
>     return false;
> }

Done.

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:286:
if (!(context instanceof Activity)) return;
On 2016/01/25 23:42:43, dfalcantara wrote:
> nit newline

Done.

https://codereview.chromium.org/1636573004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:444:
if (!(context instanceof ChromeActivity)) return;
On 2016/01/25 23:42:43, dfalcantara wrote:
> if (context instanceof ChromeActivity) {
>     ((ChromeActivity) context).getTabModelSelector().closeTab(tab);
> }

Done.

[Yusuf, 2016-01-25 23:56:09]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 00:01:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636573004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636573004/1

[Yusuf, 2016-01-26 00:32:15]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 00:33:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636573004/10010
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636573004/10010

[commit-bot: I haz the power, 2016-01-26 01:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 01:12:44]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Yusuf, 2016-01-26 01:16:06]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 01:17:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636573004/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636573004/30001

[commit-bot: I haz the power, 2016-01-26 03:25:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 03:25:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yusuf, 2016-01-26 19:45:54]

The CQ bit was checked by yusufo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 19:46:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636573004/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636573004/50001

[commit-bot: I haz the power, 2016-01-26 20:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 20:35:53]

Dry run: This issue passed the CQ dry run.

[gone, 2016-01-26 23:36:04]

lgtm

https://chromiumcodereview.appspot.com/1636573004/diff/50001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://chromiumcodereview.appspot.com/1636573004/diff/50001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:58:
protected final Context mApplicationContext;
protected final above private final

[Yusuf, 2016-01-27 18:42:15]

https://codereview.chromium.org/1636573004/diff/50001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/1636573004/diff/50001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:58:
protected final Context mApplicationContext;
On 2016/01/26 23:36:04, dfalcantara wrote:
> protected final above private final

Done.

[Yusuf, 2016-01-27 18:48:10]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2016-01-27 18:48:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1636573004/#ps70001
(title: "Nit")

[commit-bot: I haz the power, 2016-01-27 18:48:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636573004/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636573004/70001

[commit-bot: I haz the power, 2016-01-27 20:16:00]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-01-27 20:17:08]

Description was changed from

==========
Dont cache activity for external navigation handling

This removes the cached activity copies from InterceptNavigationHandler
and ExternalNavigationHandler.

- Uses application context when it doesn't make any difference(For
  package manager related calls.)
- Tries to get the activity through the tab and if not fail gracefully
  either by early return or using application context for launching new
  activity.

BUG=546736
==========

to

==========
Dont cache activity for external navigation handling

This removes the cached activity copies from InterceptNavigationHandler
and ExternalNavigationHandler.

- Uses application context when it doesn't make any difference(For
  package manager related calls.)
- Tries to get the activity through the tab and if not fail gracefully
  either by early return or using application context for launching new
  activity.

BUG=546736

Committed: https://crrev.com/d02c46df9dfd465461d14586f08745f7213c67f1
Cr-Commit-Position: refs/heads/master@{#371853}
==========

[commit-bot: I haz the power, 2016-01-27 20:17:09]

Patchset 5 (id:??) landed as
https://crrev.com/d02c46df9dfd465461d14586f08745f7213c67f1
Cr-Commit-Position: refs/heads/master@{#371853}