Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

Issue 1636573004: Dont cache activity for external navigation handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java
index 3a1de89345a572b472cf3d869db1e2a9d340f339..ea44ce32242bfcef367376e7971ecc230692b3c7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java
@@ -4,7 +4,6 @@
package org.chromium.chrome.browser.tab;
-import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.banners.AppBannerManager;
import org.chromium.chrome.browser.contextmenu.ChromeContextMenuPopulator;
import org.chromium.chrome.browser.contextmenu.ContextMenuPopulator;
@@ -27,12 +26,10 @@ public class TabDelegateFactory {
/**
* Creates the {@link InterceptNavigationDelegate} the tab will be initialized with.
* @param tab The associated {@link Tab}.
- * @param activity The {@link ChromeActivity} that the tab belongs to.
* @return The {@link InterceptNavigationDelegate} to be used for this tab.
*/
- public InterceptNavigationDelegateImpl createInterceptNavigationDelegate(
- Tab tab, ChromeActivity activity) {
- return new InterceptNavigationDelegateImpl(activity, tab);
+ public InterceptNavigationDelegateImpl createInterceptNavigationDelegate(Tab tab) {
+ return new InterceptNavigationDelegateImpl(tab);
}
/**

Powered by Google App Engine
This is Rietveld 408576698