|
|
Created:
4 years, 11 months ago by nisse-webrtc Modified:
4 years, 10 months ago CC:
webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDeleted method AudioTrackInterface::GetRenderer.
Unused in chromium since #370957.
BUG=webrtc:5426
Committed: https://crrev.com/6a062bd7afe0ab088a9ac37eafb8fc70b58fe855
Cr-Commit-Position: refs/heads/master@{#11411}
Patch Set 1 #Patch Set 2 : Delete overlooked remnants of AudioTrackInterface::GetRenderer. #Patch Set 3 : Rebase. #
Messages
Total messages: 37 (18 generated)
Description was changed from ========== Deleted method AudioTrackInterface::GetRenderer. Unused in chromium since #370957. BUG=webrtc:5426 ========== to ========== Deleted method AudioTrackInterface::GetRenderer. Unused in chromium since #370957. BUG=webrtc:5426 ==========
nisse@webrtc.org changed reviewers: + perkj@webrtc.org, xians@webrtc.org
This method carried the comment. // TODO(xians): Remove the following interface after Chrome switches to // AddSink() and RemoveSink() interfaces. As far as I understand, that time is now. Regards, /Niels
tommi@webrtc.org changed reviewers: + tommi@webrtc.org - xians@webrtc.org
Thanks! xians isn't working on webrtc anymore, so here's my lgtm instead.
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/10916)
On 2016/01/26 14:22:21, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > ios_rel on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/10916) you forgot to update the proxy.
On 2016/01/26 15:22:53, perkj_webrtc wrote: > On 2016/01/26 14:22:21, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > ios_rel on tryserver.webrtc (JOB_FAILED, > > http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/10916) > > you forgot to update the proxy. Fixed now. There was also a useless call in rtpsender.cc.
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/20001
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
The CQ bit was checked by nisse@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org Link to the patchset: https://codereview.webrtc.org/1626003004/#ps20001 (title: "Delete overlooked remnants of AudioTrackInterface::GetRenderer.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
The CQ bit was checked by nisse@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org, perkj@webrtc.org Link to the patchset: https://codereview.webrtc.org/1626003004/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/40001
Message was sent while issue was closed.
Description was changed from ========== Deleted method AudioTrackInterface::GetRenderer. Unused in chromium since #370957. BUG=webrtc:5426 ========== to ========== Deleted method AudioTrackInterface::GetRenderer. Unused in chromium since #370957. BUG=webrtc:5426 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Deleted method AudioTrackInterface::GetRenderer. Unused in chromium since #370957. BUG=webrtc:5426 ========== to ========== Deleted method AudioTrackInterface::GetRenderer. Unused in chromium since #370957. BUG=webrtc:5426 Committed: https://crrev.com/6a062bd7afe0ab088a9ac37eafb8fc70b58fe855 Cr-Commit-Position: refs/heads/master@{#11411} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6a062bd7afe0ab088a9ac37eafb8fc70b58fe855 Cr-Commit-Position: refs/heads/master@{#11411} |