Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1626003004: Deleted method AudioTrackInterface::GetRenderer. (Closed)

Created:
4 years, 11 months ago by nisse-webrtc
Modified:
4 years, 10 months ago
Reviewers:
tommi, perkj_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Deleted method AudioTrackInterface::GetRenderer. Unused in chromium since #370957. BUG=webrtc:5426 Committed: https://crrev.com/6a062bd7afe0ab088a9ac37eafb8fc70b58fe855 Cr-Commit-Position: refs/heads/master@{#11411}

Patch Set 1 #

Patch Set 2 : Delete overlooked remnants of AudioTrackInterface::GetRenderer. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M talk/app/webrtc/mediastreaminterface.h View 1 chunk +0 lines, -6 lines 0 comments Download
M talk/app/webrtc/mediastreamtrackproxy.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/rtpsender.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 37 (18 generated)
nisse-webrtc
This method carried the comment. // TODO(xians): Remove the following interface after Chrome switches to ...
4 years, 11 months ago (2016-01-25 09:36:05 UTC) #3
tommi
Thanks! xians isn't working on webrtc anymore, so here's my lgtm instead.
4 years, 11 months ago (2016-01-25 09:38:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/1
4 years, 11 months ago (2016-01-26 14:18:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/10916)
4 years, 11 months ago (2016-01-26 14:22:21 UTC) #9
perkj_webrtc
On 2016/01/26 14:22:21, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-26 15:22:53 UTC) #10
nisse-webrtc
On 2016/01/26 15:22:53, perkj_webrtc wrote: > On 2016/01/26 14:22:21, commit-bot: I haz the power wrote: ...
4 years, 11 months ago (2016-01-27 08:40:41 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/20001
4 years, 11 months ago (2016-01-27 08:40:56 UTC) #13
perkj_webrtc
lgtm
4 years, 11 months ago (2016-01-27 08:43:14 UTC) #14
perkj_webrtc
lgtm
4 years, 11 months ago (2016-01-27 08:43:15 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/602)
4 years, 11 months ago (2016-01-27 09:59:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/20001
4 years, 11 months ago (2016-01-27 13:02:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/614)
4 years, 11 months ago (2016-01-27 13:11:43 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/20001
4 years, 11 months ago (2016-01-27 13:18:12 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/618)
4 years, 11 months ago (2016-01-27 13:34:07 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/40001
4 years, 11 months ago (2016-01-27 13:43:35 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/622)
4 years, 11 months ago (2016-01-27 14:01:18 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626003004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626003004/40001
4 years, 10 months ago (2016-01-28 08:02:24 UTC) #33
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-28 08:38:16 UTC) #35
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 08:38:20 UTC) #37
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a062bd7afe0ab088a9ac37eafb8fc70b58fe855
Cr-Commit-Position: refs/heads/master@{#11411}

Powered by Google App Engine
This is Rietveld 408576698