Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: talk/app/webrtc/mediastreaminterface.h

Issue 1626003004: Deleted method AudioTrackInterface::GetRenderer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamtrackproxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 // TODO(xians): Change the interface to int GetSignalLevel() and pure virtual 228 // TODO(xians): Change the interface to int GetSignalLevel() and pure virtual
229 // after Chrome has the correct implementation of the interface. 229 // after Chrome has the correct implementation of the interface.
230 virtual bool GetSignalLevel(int* level) { return false; } 230 virtual bool GetSignalLevel(int* level) { return false; }
231 231
232 // Get the audio processor used by the audio track. Return NULL if the track 232 // Get the audio processor used by the audio track. Return NULL if the track
233 // does not have any processor. 233 // does not have any processor.
234 // TODO(xians): Make the interface pure virtual. 234 // TODO(xians): Make the interface pure virtual.
235 virtual rtc::scoped_refptr<AudioProcessorInterface> 235 virtual rtc::scoped_refptr<AudioProcessorInterface>
236 GetAudioProcessor() { return NULL; } 236 GetAudioProcessor() { return NULL; }
237 237
238 // Get a pointer to the audio renderer of this AudioTrack.
239 // The pointer is valid for the lifetime of this AudioTrack.
240 // TODO(xians): Remove the following interface after Chrome switches to
241 // AddSink() and RemoveSink() interfaces.
242 virtual cricket::AudioRenderer* GetRenderer() { return NULL; }
243
244 protected: 238 protected:
245 virtual ~AudioTrackInterface() {} 239 virtual ~AudioTrackInterface() {}
246 }; 240 };
247 241
248 typedef std::vector<rtc::scoped_refptr<AudioTrackInterface> > 242 typedef std::vector<rtc::scoped_refptr<AudioTrackInterface> >
249 AudioTrackVector; 243 AudioTrackVector;
250 typedef std::vector<rtc::scoped_refptr<VideoTrackInterface> > 244 typedef std::vector<rtc::scoped_refptr<VideoTrackInterface> >
251 VideoTrackVector; 245 VideoTrackVector;
252 246
253 class MediaStreamInterface : public rtc::RefCountInterface, 247 class MediaStreamInterface : public rtc::RefCountInterface,
(...skipping 13 matching lines...) Expand all
267 virtual bool RemoveTrack(AudioTrackInterface* track) = 0; 261 virtual bool RemoveTrack(AudioTrackInterface* track) = 0;
268 virtual bool RemoveTrack(VideoTrackInterface* track) = 0; 262 virtual bool RemoveTrack(VideoTrackInterface* track) = 0;
269 263
270 protected: 264 protected:
271 virtual ~MediaStreamInterface() {} 265 virtual ~MediaStreamInterface() {}
272 }; 266 };
273 267
274 } // namespace webrtc 268 } // namespace webrtc
275 269
276 #endif // TALK_APP_WEBRTC_MEDIASTREAMINTERFACE_H_ 270 #endif // TALK_APP_WEBRTC_MEDIASTREAMINTERFACE_H_
OLDNEW
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamtrackproxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698