webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc - Issue 1613643004: Remove mutable from rtc::CriticalSection members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc

Issue 1613643004: Remove mutable from rtc::CriticalSection members. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h ('k') | webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc

diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc b/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc

index c738d0f0957af2eab61d1ef09f8d86cd4d556d93..384db866bc45129ef730a64cea38b7ef27e66a91 100644

--- a/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc

+++ b/webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc

@@ -147,7 +147,7 @@ class PacketizationCallbackStubOldApi : public AudioPacketizationCallback {

int last_payload_type_ GUARDED_BY(crit_sect_);

uint32_t last_timestamp_ GUARDED_BY(crit_sect_);

std::vector<uint8_t> last_payload_vec_ GUARDED_BY(crit_sect_);

- mutable rtc::CriticalSection crit_sect_;

+ rtc::CriticalSection crit_sect_;

};

class AudioCodingModuleTestOldApi : public ::testing::Test {

@@ -579,7 +579,7 @@ class AudioCodingModuleMtTestOldApi : public AudioCodingModuleTestOldApi {

int send_count_;

int insert_packet_count_;

int pull_audio_count_ GUARDED_BY(crit_sect_);

- mutable rtc::CriticalSection crit_sect_;

+ rtc::CriticalSection crit_sect_;

int64_t next_insert_packet_time_ms_ GUARDED_BY(crit_sect_);

rtc::scoped_ptr<SimulatedClock> fake_clock_;

};

@@ -842,7 +842,7 @@ class AcmReRegisterIsacMtTestOldApi : public AudioCodingModuleTestOldApi {

rtc::PlatformThread receive_thread_;

rtc::PlatformThread codec_registration_thread_;

const rtc::scoped_ptr<EventWrapper> test_complete_;

- mutable rtc::CriticalSection crit_sect_;

+ rtc::CriticalSection crit_sect_;

bool codec_registered_ GUARDED_BY(crit_sect_);

int receive_packet_count_ GUARDED_BY(crit_sect_);

int64_t next_insert_packet_time_ms_ GUARDED_BY(crit_sect_);