Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1608893003: Replace hardcoded constant in video capture with macro. (Closed)

Created:
4 years, 11 months ago by kjellander_webrtc
Modified:
4 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, perkj_webrtc, mflodman, sdk-team_agora.io
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace hardcoded constant in video capture with macro. The roll in https://codereview.webrtc.org/1593713013 introduced a cast that is undefined behavior. The right way to fix it is to use a macro. NOTRY=True TESTED=Tommi verified that the values are the same. Committed: https://crrev.com/73674f80644c0e4bbf8436be8f3b8dedf959d695 Cr-Commit-Position: refs/heads/master@{#11302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/video_capture/windows/video_capture_ds.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
4 years, 11 months ago (2016-01-19 13:25:00 UTC) #1
tommi
lgtm
4 years, 11 months ago (2016-01-19 13:47:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608893003/1
4 years, 11 months ago (2016-01-19 13:48:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 13:49:23 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 13:49:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73674f80644c0e4bbf8436be8f3b8dedf959d695
Cr-Commit-Position: refs/heads/master@{#11302}

Powered by Google App Engine
This is Rietveld 408576698