Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953.
Details: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang/scripts/update.py

NOTRY=True
NOPRESUBMIT=True

Committed: https://crrev.com/3c85cad1d4e54c6e4859e4787740d64f70880c08
Cr-Commit-Position: refs/heads/master@{#11301}

[kjellander_webrtc, 2016-01-19 03:03:05]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-01-19 03:03:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593713013/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593713013/1

[commit-bot: I haz the power, 2016-01-19 03:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 03:12:40]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/10406)

[kjellander_webrtc, 2016-01-19 06:47:57]

Description was changed from

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.
No update to Clang.

TBR=
==========

to

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. See
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

TBR=
==========

[kjellander_webrtc, 2016-01-19 06:58:28]

Description was changed from

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. See
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

TBR=
==========

to

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. 
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

TBR=
==========

[kjellander_webrtc, 2016-01-19 07:04:15]

kjellander@webrtc.org changed reviewers:
+ perkj@webrtc.org

[kjellander_webrtc, 2016-01-19 07:40:16]

Patchset #2 (id:20001) has been deleted

[kjellander_webrtc, 2016-01-19 07:59:19]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org

[kjellander_webrtc, 2016-01-19 08:39:05]

I had to fix/disable a bunch of warnings to make this pass.
henrika: webrtc/modules/audio_device
perkj: the rest.

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_rend...
File webrtc/modules/video_render/windows/video_render_direct3d9.cc (left):

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_rend...
webrtc/modules/video_render/windows/video_render_direct3d9.cc:1128: if
(_totalMemory == -1 || _availableMemory == -1)
This code must have been dead forever :)

[henrika_webrtc, 2016-01-19 08:53:57]

LGTM

[henrika_webrtc, 2016-01-19 08:55:17]

It might be better to introduce size_t instead but that will spread more in the
code. I am fine as is.

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
File webrtc/modules/video_capture/windows/video_capture_ds.cc (right):

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
webrtc/modules/video_capture/windows/video_capture_ds.cc:398: if (hr ==
(long)0x80070004)
Could you use a suffix here, like 0x80070004L?

[kjellander_webrtc, 2016-01-19 09:18:21]

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
File webrtc/modules/video_capture/windows/video_capture_ds.cc (right):

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
webrtc/modules/video_capture/windows/video_capture_ds.cc:398: if (hr ==
(long)0x80070004)
On 2016/01/19 08:55:17, henrika_webrtc wrote:
> Could you use a suffix here, like 0x80070004L?

I tried, but it becomes an unsigned long even if
https://msdn.microsoft.com/en-us/library/00a1awxf.aspx says that the L suffix
should produce a signed long.
Maybe that's a bug in the Windows Clang compiler?

Since _graphBuilder->ConnectDirect returns a signed long I was out of options.
It seemed risky to cast that long to be unsigned...

[kjellander_webrtc, 2016-01-19 09:19:23]

On 2016/01/19 08:55:17, henrika_webrtc wrote:
> It might be better to introduce size_t instead but that will spread more in
the
> code. I am fine as is.

Yeah, I think that can turn out to be a major effort. pkasting spent a lot of
time doing this in our APIs, so it might be easier than before at least.
I'd like to keep changes minimal here.

> 
>
https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
> File webrtc/modules/video_capture/windows/video_capture_ds.cc (right):
> 
>
https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
> webrtc/modules/video_capture/windows/video_capture_ds.cc:398: if (hr ==
> (long)0x80070004)
> Could you use a suffix here, like 0x80070004L?

[henrika_webrtc, 2016-01-19 09:24:14]

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
File webrtc/modules/video_capture/windows/video_capture_ds.cc (right):

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
webrtc/modules/video_capture/windows/video_capture_ds.cc:398: if (hr ==
(long)0x80070004)
never mind, but L or l should be long (see
http://en.cppreference.com/w/cpp/language/integer_literal)

[hbos, 2016-01-19 09:30:38]

Hmm, note that this roll is in progress:
https://codereview.webrtc.org/1607753002/

[kjellander_webrtc, 2016-01-19 10:03:58]

On 2016/01/19 09:30:38, hbos wrote:
> Hmm, note that this roll is in progress:
> https://codereview.webrtc.org/1607753002/

yeah, that CL is useless unless these changes are applied. We'll have to create
another one once this is in.

[perkj_webrtc, 2016-01-19 10:08:38]

lgtm

[kjellander_webrtc, 2016-01-19 10:09:07]

Description was changed from

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. 
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

TBR=
==========

to

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. 
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

NOTRY=True
==========

[kjellander_webrtc, 2016-01-19 12:27:38]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-01-19 12:27:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593713013/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593713013/40001

[commit-bot: I haz the power, 2016-01-19 12:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 12:33:10]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2939)

[kjellander_webrtc, 2016-01-19 12:46:50]

Description was changed from

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. 
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

NOTRY=True
==========

to

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. 
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

NOTRY=True
NOPRESUBMIT=True
==========

[kjellander_webrtc, 2016-01-19 12:47:03]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-01-19 12:47:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593713013/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593713013/40001

[commit-bot: I haz the power, 2016-01-19 12:47:21]

Description was changed from

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. 
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

NOTRY=True
NOPRESUBMIT=True
==========

to

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. 
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

NOTRY=True
NOPRESUBMIT=True
==========

[commit-bot: I haz the power, 2016-01-19 12:47:21]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-01-19 12:47:28]

Description was changed from

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953. 
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

NOTRY=True
NOPRESUBMIT=True
==========

to

==========
Roll chromium_revision 7a4fb8d..f527e86 (370025:370073)

Change log: https://chromium.googlesource.com/chromium/src/+log/7a4fb8d..f527e86
Full diff: https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86

No dependencies changed.

Clang was updated 255169:257953.
Details:
https://chromium.googlesource.com/chromium/src/+/7a4fb8d..f527e86/tools/clang...

NOTRY=True
NOPRESUBMIT=True

Committed: https://crrev.com/3c85cad1d4e54c6e4859e4787740d64f70880c08
Cr-Commit-Position: refs/heads/master@{#11301}
==========

[commit-bot: I haz the power, 2016-01-19 12:47:29]

Patchset 2 (id:??) landed as
https://crrev.com/3c85cad1d4e54c6e4859e4787740d64f70880c08
Cr-Commit-Position: refs/heads/master@{#11301}

[torbjorng (webrtc), 2016-01-19 13:10:01]

torbjorng@webrtc.org changed reviewers:
+ torbjorng@webrtc.org

[torbjorng (webrtc), 2016-01-19 13:10:02]

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
File webrtc/modules/video_capture/windows/video_capture_ds.cc (right):

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
webrtc/modules/video_capture/windows/video_capture_ds.cc:398: if (hr ==
(long)0x80070004)
On 2016/01/19 09:24:14, henrika_webrtc wrote:
> never mind, but L or l should be long (see
> http://en.cppreference.com/w/cpp/language/integer_literal)

My understanding is that on systems where "long" is a 32-bit type the constant
0x80070004L is promoted to "unsigned long" as "long" does not fit the constant.

If that promoted constant is then used in a context of wider type (64 bits) it
will be zero extended to that width.

Note that (long)0x80070004 is undefined when long is < 33 bits as it will yield
a signed overflow.  :-(

[kjellander_webrtc, 2016-01-19 13:48:58]

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
File webrtc/modules/video_capture/windows/video_capture_ds.cc (right):

https://codereview.webrtc.org/1593713013/diff/40001/webrtc/modules/video_capt...
webrtc/modules/video_capture/windows/video_capture_ds.cc:398: if (hr ==
(long)0x80070004)
On 2016/01/19 13:10:02, torbjorng (webrtc) wrote:
> On 2016/01/19 09:24:14, henrika_webrtc wrote:
> > never mind, but L or l should be long (see
> > http://en.cppreference.com/w/cpp/language/integer_literal)
> 
> My understanding is that on systems where "long" is a 32-bit type the constant
> 0x80070004L is promoted to "unsigned long" as "long" does not fit the
constant.
> 
> If that promoted constant is then used in a context of wider type (64 bits) it
> will be zero extended to that width.
> 
> Note that (long)0x80070004 is undefined when long is < 33 bits as it will
yield
> a signed overflow.  :-(

Thanks for the input. Tommi suggested a better solution which was implemented in
https://codereview.webrtc.org/1608893003/.