Make CriticalSectionWrapper non-virtual

Make CriticalSectionWrapper non-virtual.
There's no need for this class to have a vtable since there exists only a single implementation (per platform).  It's also not good for performance.

BUG=
R=pbos@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/ee5a309f12e4a3f96b8924d45e65ae01ef18d079

[tommi, 2016-01-19 11:17:44]

Windows changes

[tommi, 2016-01-19 11:22:01]

Rebase

[tommi, 2016-01-19 12:54:26]

Fix windows build

[tommi, 2016-01-19 12:56:33]

Description was changed from

==========
Make CriticalSectionWrapper non-virtual

BUG=
==========

to

==========
Make CriticalSectionWrapper non-virtual.
There's no need for this class to have a vtable since there exists only a single
implementation (per platform).  It's also not good for performance.

BUG=
==========

[tommi, 2016-01-19 12:56:33]

tommi@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-01-19 13:04:41]

lgtm w/ enum renamed instead of undef.

https://codereview.webrtc.org/1601743004/diff/60001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc (right):

https://codereview.webrtc.org/1601743004/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc:93: enum logic
{
Can we rename the enum in here instead? Pref kIgnore, kEqual...

https://codereview.webrtc.org/1601743004/diff/60001/webrtc/system_wrappers/in...
File webrtc/system_wrappers/include/critical_section_wrapper.h (right):

https://codereview.webrtc.org/1601743004/diff/60001/webrtc/system_wrappers/in...
webrtc/system_wrappers/include/critical_section_wrapper.h:31: // TODO(tommi):
Remove this method.
The real TODO should imo be to nuke this file and use rtc::CriticalSection
instead.

[tommi, 2016-01-19 13:49:46]

Change enum value names

[tommi, 2016-01-19 13:57:01]

Improve comment

[tommi, 2016-01-19 13:57:15]

https://codereview.webrtc.org/1601743004/diff/60001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc (right):

https://codereview.webrtc.org/1601743004/diff/60001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc:93: enum logic
{
On 2016/01/19 13:04:41, pbos-webrtc wrote:
> Can we rename the enum in here instead? Pref kIgnore, kEqual...

Done.

https://codereview.webrtc.org/1601743004/diff/60001/webrtc/system_wrappers/in...
File webrtc/system_wrappers/include/critical_section_wrapper.h (right):

https://codereview.webrtc.org/1601743004/diff/60001/webrtc/system_wrappers/in...
webrtc/system_wrappers/include/critical_section_wrapper.h:31: // TODO(tommi):
Remove this method.
On 2016/01/19 13:04:41, pbos-webrtc wrote:
> The real TODO should imo be to nuke this file and use rtc::CriticalSection
> instead.

Right... I'll see if we can get rid of the ConditionVariableWrapper class, which
is currently preventing us from doing that.  Comment updated.

[tommi, 2016-01-19 13:57:21]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-01-19 13:57:21]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1601743004/#ps100001 (title:
"Improve comment")

[commit-bot: I haz the power, 2016-01-19 13:57:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1601743004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1601743004/100001

[commit-bot: I haz the power, 2016-01-19 14:02:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 14:02:45]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2944)

[commit-bot: I haz the power, 2016-01-19 14:43:00]

Description was changed from

==========
Make CriticalSectionWrapper non-virtual.
There's no need for this class to have a vtable since there exists only a single
implementation (per platform).  It's also not good for performance.

BUG=
==========

to

==========
Make CriticalSectionWrapper non-virtual.
There's no need for this class to have a vtable since there exists only a single
implementation (per platform).  It's also not good for performance.

BUG=
R=pbos@webrtc.org

Committed: https://crrev.com/ee5a309f12e4a3f96b8924d45e65ae01ef18d079
Cr-Commit-Position: refs/heads/master@{#11306}
==========

[commit-bot: I haz the power, 2016-01-19 14:43:01]

Patchset 6 (id:??) landed as
https://crrev.com/ee5a309f12e4a3f96b8924d45e65ae01ef18d079
Cr-Commit-Position: refs/heads/master@{#11306}

[tommi, 2016-01-19 14:43:01]

Description was changed from

==========
Make CriticalSectionWrapper non-virtual.
There's no need for this class to have a vtable since there exists only a single
implementation (per platform).  It's also not good for performance.

BUG=
R=pbos@webrtc.org

Committed: https://crrev.com/ee5a309f12e4a3f96b8924d45e65ae01ef18d079
Cr-Commit-Position: refs/heads/master@{#11306}
==========

to

==========
Make CriticalSectionWrapper non-virtual.
There's no need for this class to have a vtable since there exists only a single
implementation (per platform).  It's also not good for performance.

BUG=
R=pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ee5a309f12e4a3f96b8924d45...
==========

[tommi, 2016-01-19 14:43:02]

Committed patchset #6 (id:100001) manually as
ee5a309f12e4a3f96b8924d45e65ae01ef18d079 (presubmit successful).