Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: webrtc/system_wrappers/include/critical_section_wrapper.h

Issue 1601743004: Make CriticalSectionWrapper non-virtual (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Improve comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_SYSTEM_WRAPPERS_INCLUDE_CRITICAL_SECTION_WRAPPER_H_ 11 #ifndef WEBRTC_SYSTEM_WRAPPERS_INCLUDE_CRITICAL_SECTION_WRAPPER_H_
12 #define WEBRTC_SYSTEM_WRAPPERS_INCLUDE_CRITICAL_SECTION_WRAPPER_H_ 12 #define WEBRTC_SYSTEM_WRAPPERS_INCLUDE_CRITICAL_SECTION_WRAPPER_H_
13 13
14 // If the critical section is heavily contended it may be beneficial to use 14 // If the critical section is heavily contended it may be beneficial to use
15 // read/write locks instead. 15 // read/write locks instead.
16 16
17 #if defined (WEBRTC_WIN)
18 #include <windows.h>
19 #else
20 #include <pthread.h>
21 #endif
22
17 #include "webrtc/base/thread_annotations.h" 23 #include "webrtc/base/thread_annotations.h"
18 #include "webrtc/common_types.h" 24 #include "webrtc/common_types.h"
19 25
20 namespace webrtc { 26 namespace webrtc {
27
21 class LOCKABLE CriticalSectionWrapper { 28 class LOCKABLE CriticalSectionWrapper {
22 public: 29 public:
23 // Factory method, constructor disabled 30 // Legacy factory method, being deprecated. Please use the constructor.
31 // TODO(tommi): Remove the CriticalSectionWrapper class and move users over
32 // to using rtc::CriticalSection. Before we can do that though, we need to
33 // fix the problem with the ConditionVariable* classes (see below).
24 static CriticalSectionWrapper* CreateCriticalSection(); 34 static CriticalSectionWrapper* CreateCriticalSection();
25 35
26 virtual ~CriticalSectionWrapper() {} 36 CriticalSectionWrapper();
37 ~CriticalSectionWrapper();
27 38
28 // Tries to grab lock, beginning of a critical section. Will wait for the 39 // Tries to grab lock, beginning of a critical section. Will wait for the
29 // lock to become available if the grab failed. 40 // lock to become available if the grab failed.
30 virtual void Enter() EXCLUSIVE_LOCK_FUNCTION() = 0; 41 void Enter() EXCLUSIVE_LOCK_FUNCTION();
31 42
32 // Returns a grabbed lock, end of critical section. 43 // Returns a grabbed lock, end of critical section.
33 virtual void Leave() UNLOCK_FUNCTION() = 0; 44 void Leave() UNLOCK_FUNCTION();
45
46 private:
47 #if defined (WEBRTC_WIN)
48 CRITICAL_SECTION crit_;
49
50 // TODO(tommi): Remove friendness.
51 friend class ConditionVariableEventWin;
52 friend class ConditionVariableNativeWin;
53 #else
54 // TODO(tommi): Remove friendness.
55 pthread_mutex_t mutex_;
56 friend class ConditionVariablePosix;
57 #endif
34 }; 58 };
35 59
36 // RAII extension of the critical section. Prevents Enter/Leave mismatches and 60 // RAII extension of the critical section. Prevents Enter/Leave mismatches and
37 // provides more compact critical section syntax. 61 // provides more compact critical section syntax.
38 class SCOPED_LOCKABLE CriticalSectionScoped { 62 class SCOPED_LOCKABLE CriticalSectionScoped {
39 public: 63 public:
40 explicit CriticalSectionScoped(CriticalSectionWrapper* critsec) 64 explicit CriticalSectionScoped(CriticalSectionWrapper* critsec)
41 EXCLUSIVE_LOCK_FUNCTION(critsec) 65 EXCLUSIVE_LOCK_FUNCTION(critsec)
42 : ptr_crit_sec_(critsec) { 66 : ptr_crit_sec_(critsec) {
43 ptr_crit_sec_->Enter(); 67 ptr_crit_sec_->Enter();
44 } 68 }
45 69
46 ~CriticalSectionScoped() UNLOCK_FUNCTION() { ptr_crit_sec_->Leave(); } 70 ~CriticalSectionScoped() UNLOCK_FUNCTION() { ptr_crit_sec_->Leave(); }
47 71
48 private: 72 private:
49 CriticalSectionWrapper* ptr_crit_sec_; 73 CriticalSectionWrapper* ptr_crit_sec_;
50 }; 74 };
51 75
52 } // namespace webrtc 76 } // namespace webrtc
53 77
54 #endif // WEBRTC_SYSTEM_WRAPPERS_INCLUDE_CRITICAL_SECTION_WRAPPER_H_ 78 #endif // WEBRTC_SYSTEM_WRAPPERS_INCLUDE_CRITICAL_SECTION_WRAPPER_H_
OLDNEW
« no previous file with comments | « webrtc/system_wrappers/BUILD.gn ('k') | webrtc/system_wrappers/source/condition_variable_event_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698