Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1601523009: Remove ConditionVariableWrapper. (Closed)

Created:
4 years, 11 months ago by tommi
Modified:
4 years, 11 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ConditionVariableWrapper. ConditionVariableEventWin remains for now since it's still needed for the rw lock on Windows XP. BUG= R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/e8493326f27dd0d6624f6137315fb8ab1223e277

Patch Set 1 #

Patch Set 2 : Unfriend #

Patch Set 3 : Move include inside guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -306 lines) Patch
M webrtc/system_wrappers/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D webrtc/system_wrappers/include/condition_variable_wrapper.h View 1 chunk +0 lines, -49 lines 0 comments Download
M webrtc/system_wrappers/include/critical_section_wrapper.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/system_wrappers/source/condition_variable.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M webrtc/system_wrappers/source/condition_variable_event_win.h View 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/system_wrappers/source/condition_variable_event_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
D webrtc/system_wrappers/source/condition_variable_native_win.h View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/system_wrappers/source/condition_variable_native_win.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M webrtc/system_wrappers/source/condition_variable_unittest.cc View 1 2 6 chunks +32 lines, -34 lines 0 comments Download
M webrtc/system_wrappers/source/rw_lock_winxp_win.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/system_wrappers/source/rw_lock_winxp_win.cc View 4 chunks +26 lines, -8 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
tommi
Unfriend
4 years, 11 months ago (2016-01-19 22:28:17 UTC) #1
tommi
Move include inside guard
4 years, 11 months ago (2016-01-19 22:32:20 UTC) #2
tommi
4 years, 11 months ago (2016-01-19 22:39:36 UTC) #4
pbos-webrtc
lgtm
4 years, 11 months ago (2016-01-20 11:48:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601523009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601523009/40001
4 years, 11 months ago (2016-01-20 12:32:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2966)
4 years, 11 months ago (2016-01-20 12:34:33 UTC) #9
tommi
Committed patchset #3 (id:40001) manually as e8493326f27dd0d6624f6137315fb8ab1223e277 (presubmit successful).
4 years, 11 months ago (2016-01-20 12:36:48 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 12:36:48 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e8493326f27dd0d6624f6137315fb8ab1223e277
Cr-Commit-Position: refs/heads/master@{#11317}

Powered by Google App Engine
This is Rietveld 408576698