webrtc/system_wrappers/include/critical_section_wrapper.h - Issue 1601523009: Remove ConditionVariableWrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/include/critical_section_wrapper.h

Issue 1601523009: Remove ConditionVariableWrapper. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Move include inside guard Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/system_wrappers/include/critical_section_wrapper.h

diff --git a/webrtc/system_wrappers/include/critical_section_wrapper.h b/webrtc/system_wrappers/include/critical_section_wrapper.h

index c22d22afdc7640227f88f3b679f6b4d888dfb583..777dec5cf0aae767af10823cea8801abeec09ccb 100644

--- a/webrtc/system_wrappers/include/critical_section_wrapper.h

+++ b/webrtc/system_wrappers/include/critical_section_wrapper.h

@@ -46,10 +46,6 @@ class LOCKABLE CriticalSectionWrapper {

private:

#if defined (WEBRTC_WIN)

CRITICAL_SECTION crit_;

- // TODO(tommi): Remove friendness.

- friend class ConditionVariableEventWin;

- friend class ConditionVariableNativeWin;

#else

pthread_mutex_t mutex_;

#endif