Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: talk/media/base/videorenderer.h

Issue 1594973006: New rtc::VideoSinkInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nits. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/base/videorenderer.h
diff --git a/talk/media/base/videorenderer.h b/talk/media/base/videorenderer.h
index 0b159f3af7864ff2db12290f570f6ef99fdc1847..03204030f08d078839e3e7d2d83623dbe681d983 100644
--- a/talk/media/base/videorenderer.h
+++ b/talk/media/base/videorenderer.h
@@ -33,18 +33,23 @@
#endif
#include "webrtc/base/sigslot.h"
+#include "webrtc/media/base/videosinkinterface.h"
namespace cricket {
class VideoFrame;
// Abstract interface for rendering VideoFrames.
-class VideoRenderer {
+class VideoRenderer : public rtc::VideoSinkInterface<VideoFrame> {
public:
virtual ~VideoRenderer() {}
// Called when a new frame is available for display.
virtual bool RenderFrame(const VideoFrame *frame) = 0;
-
+ // Intended to replace RenderFrame.
+ void OnFrame(const cricket::VideoFrame& frame) override {
+ // Unused return value
+ RenderFrame(&frame);
+ }
#if !defined(NDEBUG)
// Allow renderer dumping out rendered frames.
virtual bool SetDumpPath(const std::string &path) { return true; }

Powered by Google App Engine
This is Rietveld 408576698