Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: talk/media/webrtc/webrtcvideoengine2.h

Issue 1594973006: New rtc::VideoSinkInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nits. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/webrtc/webrtcvideoengine2.h
diff --git a/talk/media/webrtc/webrtcvideoengine2.h b/talk/media/webrtc/webrtcvideoengine2.h
index eb2480c4cbde614ff43b6afc8ed6397aebb79787..b997e836fd4ed2eddd569a39b59d5f0db454516f 100644
--- a/talk/media/webrtc/webrtcvideoengine2.h
+++ b/talk/media/webrtc/webrtcvideoengine2.h
@@ -40,6 +40,7 @@
#include "webrtc/base/scoped_ptr.h"
#include "webrtc/base/thread_annotations.h"
#include "webrtc/base/thread_checker.h"
+#include "webrtc/media/base/videosinkinterface.h"
#include "webrtc/call.h"
#include "webrtc/transport.h"
#include "webrtc/video_frame.h"
@@ -413,7 +414,7 @@ class WebRtcVideoChannel2 : public rtc::MessageHandler,
bool SmoothsRenderedFrames() const override;
bool IsDefaultStream() const;
- void SetRenderer(cricket::VideoRenderer* renderer);
+ void SetSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink);
VideoReceiverInfo GetVideoReceiverInfo();
@@ -451,18 +452,18 @@ class WebRtcVideoChannel2 : public rtc::MessageHandler,
const bool disable_prerenderer_smoothing_;
- rtc::CriticalSection renderer_lock_;
- cricket::VideoRenderer* renderer_ GUARDED_BY(renderer_lock_);
- int last_width_ GUARDED_BY(renderer_lock_);
- int last_height_ GUARDED_BY(renderer_lock_);
+ rtc::CriticalSection sink_lock_;
+ rtc::VideoSinkInterface<cricket::VideoFrame>* sink_ GUARDED_BY(sink_lock_);
+ int last_width_ GUARDED_BY(sink_lock_);
+ int last_height_ GUARDED_BY(sink_lock_);
// Expands remote RTP timestamps to int64_t to be able to estimate how long
// the stream has been running.
rtc::TimestampWrapAroundHandler timestamp_wraparound_handler_
- GUARDED_BY(renderer_lock_);
- int64_t first_frame_timestamp_ GUARDED_BY(renderer_lock_);
+ GUARDED_BY(sink_lock_);
+ int64_t first_frame_timestamp_ GUARDED_BY(sink_lock_);
// Start NTP time is estimated as current remote NTP time (estimated from
// RTCP) minus the elapsed time, as soon as remote NTP time is available.
- int64_t estimated_remote_start_ntp_time_ms_ GUARDED_BY(renderer_lock_);
+ int64_t estimated_remote_start_ntp_time_ms_ GUARDED_BY(sink_lock_);
};
void Construct(webrtc::Call* call, WebRtcVideoEngine2* engine);

Powered by Google App Engine
This is Rietveld 408576698