Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1590883002: [rtp_rtcp] rtcp::Remb moved into own file (Closed)

Created:
4 years, 11 months ago by danilchap
Modified:
4 years, 11 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] rtcp::Remb moved into own file Cleaning/Parsing will be done in the https://codereview.webrtc.org/1552773002/ BUG=webrtc:5260 R=asapersson@webrtc.org, åsapersson Committed: https://crrev.com/a5eba6c98b0f524f69fba2a3cdb6676bbfcd3723 Cr-Commit-Position: refs/heads/master@{#11268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -181 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 chunk +0 lines, -56 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 4 chunks +0 lines, -84 lines 0 comments Download
A + webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h View 3 chunks +20 lines, -20 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
åsapersson
lgtm
4 years, 11 months ago (2016-01-15 11:19:28 UTC) #1
danilchap
Committed patchset #1 (id:1) manually as a5eba6c98b0f524f69fba2a3cdb6676bbfcd3723 (presubmit successful).
4 years, 11 months ago (2016-01-15 11:40:32 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 11:40:32 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5eba6c98b0f524f69fba2a3cdb6676bbfcd3723
Cr-Commit-Position: refs/heads/master@{#11268}

Powered by Google App Engine
This is Rietveld 408576698