Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

Issue 1590883002: [rtp_rtcp] rtcp::Remb moved into own file (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc
index 22f61f5cab9b6a6791cc225d2172e7847a783c84..c9610560d6dae5d1e23c3cd29c7c9e6ab9c8ffa9 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc
@@ -27,7 +27,6 @@ using webrtc::rtcp::Dlrr;
using webrtc::rtcp::Fir;
using webrtc::rtcp::RawPacket;
using webrtc::rtcp::ReceiverReport;
-using webrtc::rtcp::Remb;
using webrtc::rtcp::ReportBlock;
using webrtc::rtcp::Rpsi;
using webrtc::rtcp::Rrtr;
@@ -324,26 +323,6 @@ TEST(RtcpPacketTest, BuildWithTooSmallBuffer) {
EXPECT_FALSE(rr.BuildExternalBuffer(buffer, kBufferSize, &verifier));
}
-TEST(RtcpPacketTest, Remb) {
- Remb remb;
- remb.From(kSenderSsrc);
- remb.AppliesTo(kRemoteSsrc);
- remb.AppliesTo(kRemoteSsrc + 1);
- remb.AppliesTo(kRemoteSsrc + 2);
- remb.WithBitrateBps(261011);
-
- rtc::scoped_ptr<RawPacket> packet(remb.Build());
- RtcpPacketParser parser;
- parser.Parse(packet->Buffer(), packet->Length());
- EXPECT_EQ(1, parser.psfb_app()->num_packets());
- EXPECT_EQ(kSenderSsrc, parser.psfb_app()->Ssrc());
- EXPECT_EQ(1, parser.remb_item()->num_packets());
- EXPECT_EQ(261011, parser.remb_item()->last_bitrate_bps());
- std::vector<uint32_t> ssrcs = parser.remb_item()->last_ssrc_list();
- EXPECT_EQ(kRemoteSsrc, ssrcs[0]);
- EXPECT_EQ(kRemoteSsrc + 1, ssrcs[1]);
- EXPECT_EQ(kRemoteSsrc + 2, ssrcs[2]);
-}
TEST(RtcpPacketTest, XrWithNoReportBlocks) {
Xr xr;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698