Revert of Use an explicit identifier in Config

Revert of Use an explicit identifier in Config (patchset #4 id:60001 of https://codereview.webrtc.org/1538643004/ )

Reason for revert:
Reverting due to problem with roll:

/b/build/slave/linux/build/src/buildtools/linux64/gn gen //out/Release '--args=ffmpeg_branding="Chrome" proprietary_codecs=true is_debug=false is_component_build=false use_goma=true goma_dir="/b/build/goma" symbol_level=1 dcheck_always_on=true' --check --runtime-deps-list-file=/b/build/slave/linux/build/src/out/Release/runtime_deps
  -> returned 1
ERROR at //third_party/webrtc/BUILD.gn:245:18: Item not found
    configs -= [ "//build/config/clang:find_bad_constructs" ]
                 ^-----------------------------------------
You were trying to remove "//build/config/clang:find_bad_constructs"
from the list but it wasn't there.
GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Original issue's description:
> Use an explicit identifier in Config
>
> This let's us use them to configure them when using WebRTC as an external library. One use case where this is necessary is in the Android OS.
>
> Committed: https://crrev.com/25249d92d3cf105bcc7b684c8924ccdbc9afcb93
> Cr-Commit-Position: refs/heads/master@{#11231}

TBR=henrik.lundin@webrtc.org,stefan@webrtc.org,tommi@chromium.org,aluebs@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/fca54f41ad1b5b2189d123fe8e97f3ff9b457336
Cr-Commit-Position: refs/heads/master@{#11239}

[tommi, 2016-01-13 16:11:46]

Created Revert of Use an explicit identifier in Config

[commit-bot: I haz the power, 2016-01-13 16:11:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586563003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586563003/1

[commit-bot: I haz the power, 2016-01-13 16:12:03]

Description was changed from

==========
Revert of Use an explicit identifier in Config (patchset #4 id:60001 of
https://codereview.webrtc.org/1538643004/ )

Reason for revert:
Reverting due to problem with roll:

/b/build/slave/linux/build/src/buildtools/linux64/gn gen //out/Release
'--args=ffmpeg_branding="Chrome" proprietary_codecs=true is_debug=false
is_component_build=false use_goma=true goma_dir="/b/build/goma" symbol_level=1
dcheck_always_on=true' --check
--runtime-deps-list-file=/b/build/slave/linux/build/src/out/Release/runtime_deps
  -> returned 1
ERROR at //third_party/webrtc/BUILD.gn:245:18: Item not found
    configs -= [ "//build/config/clang:find_bad_constructs" ]
                 ^-----------------------------------------
You were trying to remove "//build/config/clang:find_bad_constructs"
from the list but it wasn't there.
GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Original issue's description:
> Use an explicit identifier in Config
> 
> This let's us use them to configure them when using WebRTC as an external
library. One use case where this is necessary is in the Android OS.
> 
> Committed: https://crrev.com/25249d92d3cf105bcc7b684c8924ccdbc9afcb93
> Cr-Commit-Position: refs/heads/master@{#11231}

TBR=henrik.lundin@webrtc.org,stefan@webrtc.org,tommi@chromium.org,aluebs@webr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Use an explicit identifier in Config (patchset #4 id:60001 of
https://codereview.webrtc.org/1538643004/ )

Reason for revert:
Reverting due to problem with roll:

/b/build/slave/linux/build/src/buildtools/linux64/gn gen //out/Release
'--args=ffmpeg_branding="Chrome" proprietary_codecs=true is_debug=false
is_component_build=false use_goma=true goma_dir="/b/build/goma" symbol_level=1
dcheck_always_on=true' --check
--runtime-deps-list-file=/b/build/slave/linux/build/src/out/Release/runtime_deps
  -> returned 1
ERROR at //third_party/webrtc/BUILD.gn:245:18: Item not found
    configs -= [ "//build/config/clang:find_bad_constructs" ]
                 ^-----------------------------------------
You were trying to remove "//build/config/clang:find_bad_constructs"
from the list but it wasn't there.
GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Original issue's description:
> Use an explicit identifier in Config
> 
> This let's us use them to configure them when using WebRTC as an external
library. One use case where this is necessary is in the Android OS.
> 
> Committed: https://crrev.com/25249d92d3cf105bcc7b684c8924ccdbc9afcb93
> Cr-Commit-Position: refs/heads/master@{#11231}

TBR=henrik.lundin@webrtc.org,stefan@webrtc.org,tommi@chromium.org,aluebs@webr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-01-13 16:12:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-13 16:12:10]

Description was changed from

==========
Revert of Use an explicit identifier in Config (patchset #4 id:60001 of
https://codereview.webrtc.org/1538643004/ )

Reason for revert:
Reverting due to problem with roll:

/b/build/slave/linux/build/src/buildtools/linux64/gn gen //out/Release
'--args=ffmpeg_branding="Chrome" proprietary_codecs=true is_debug=false
is_component_build=false use_goma=true goma_dir="/b/build/goma" symbol_level=1
dcheck_always_on=true' --check
--runtime-deps-list-file=/b/build/slave/linux/build/src/out/Release/runtime_deps
  -> returned 1
ERROR at //third_party/webrtc/BUILD.gn:245:18: Item not found
    configs -= [ "//build/config/clang:find_bad_constructs" ]
                 ^-----------------------------------------
You were trying to remove "//build/config/clang:find_bad_constructs"
from the list but it wasn't there.
GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Original issue's description:
> Use an explicit identifier in Config
> 
> This let's us use them to configure them when using WebRTC as an external
library. One use case where this is necessary is in the Android OS.
> 
> Committed: https://crrev.com/25249d92d3cf105bcc7b684c8924ccdbc9afcb93
> Cr-Commit-Position: refs/heads/master@{#11231}

TBR=henrik.lundin@webrtc.org,stefan@webrtc.org,tommi@chromium.org,aluebs@webr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Use an explicit identifier in Config (patchset #4 id:60001 of
https://codereview.webrtc.org/1538643004/ )

Reason for revert:
Reverting due to problem with roll:

/b/build/slave/linux/build/src/buildtools/linux64/gn gen //out/Release
'--args=ffmpeg_branding="Chrome" proprietary_codecs=true is_debug=false
is_component_build=false use_goma=true goma_dir="/b/build/goma" symbol_level=1
dcheck_always_on=true' --check
--runtime-deps-list-file=/b/build/slave/linux/build/src/out/Release/runtime_deps
  -> returned 1
ERROR at //third_party/webrtc/BUILD.gn:245:18: Item not found
    configs -= [ "//build/config/clang:find_bad_constructs" ]
                 ^-----------------------------------------
You were trying to remove "//build/config/clang:find_bad_constructs"
from the list but it wasn't there.
GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Original issue's description:
> Use an explicit identifier in Config
>
> This let's us use them to configure them when using WebRTC as an external
library. One use case where this is necessary is in the Android OS.
>
> Committed: https://crrev.com/25249d92d3cf105bcc7b684c8924ccdbc9afcb93
> Cr-Commit-Position: refs/heads/master@{#11231}

TBR=henrik.lundin@webrtc.org,stefan@webrtc.org,tommi@chromium.org,aluebs@webr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/fca54f41ad1b5b2189d123fe8e97f3ff9b457336
Cr-Commit-Position: refs/heads/master@{#11239}
==========

[commit-bot: I haz the power, 2016-01-13 16:12:11]

Patchset 1 (id:??) landed as
https://crrev.com/fca54f41ad1b5b2189d123fe8e97f3ff9b457336
Cr-Commit-Position: refs/heads/master@{#11239}

[aluebs-google, 2016-01-13 18:35:33]

aluebs@google.com changed reviewers:
+ aluebs@google.com

[aluebs-google, 2016-01-13 18:35:33]

lgtm

[aluebs-webrtc, 2016-01-13 23:44:47]

lgtm

[hlundin-webrtc, 2016-01-14 08:57:31]

RS-LGTM