Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: webrtc/config.h

Issue 1586563003: Revert of Use an explicit identifier in Config (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/common.h ('k') | webrtc/modules/audio_processing/include/audio_processing.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 // TODO(pbos): Move Config from common.h to here. 11 // TODO(pbos): Move Config from common.h to here.
12 12
13 #ifndef WEBRTC_CONFIG_H_ 13 #ifndef WEBRTC_CONFIG_H_
14 #define WEBRTC_CONFIG_H_ 14 #define WEBRTC_CONFIG_H_
15 15
16 #include <string> 16 #include <string>
17 #include <vector> 17 #include <vector>
18 18
19 #include "webrtc/common.h"
20 #include "webrtc/common_types.h" 19 #include "webrtc/common_types.h"
21 #include "webrtc/typedefs.h" 20 #include "webrtc/typedefs.h"
22 21
23 namespace webrtc { 22 namespace webrtc {
24 23
25 // Settings for NACK, see RFC 4585 for details. 24 // Settings for NACK, see RFC 4585 for details.
26 struct NackConfig { 25 struct NackConfig {
27 NackConfig() : rtp_history_ms(0) {} 26 NackConfig() : rtp_history_ms(0) {}
28 // Send side: the time RTP packets are stored for retransmissions. 27 // Send side: the time RTP packets are stored for retransmissions.
29 // Receive side: the time the receiver is prepared to wait for 28 // Receive side: the time the receiver is prepared to wait for
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 // Controls the capacity of the packet buffer in NetEq. The capacity is the 121 // Controls the capacity of the packet buffer in NetEq. The capacity is the
123 // maximum number of packets that the buffer can contain. If the limit is 122 // maximum number of packets that the buffer can contain. If the limit is
124 // exceeded, the buffer will be flushed. The capacity does not affect the actual 123 // exceeded, the buffer will be flushed. The capacity does not affect the actual
125 // audio delay in the general case, since this is governed by the target buffer 124 // audio delay in the general case, since this is governed by the target buffer
126 // level (calculated from the jitter profile). It is only in the rare case of 125 // level (calculated from the jitter profile). It is only in the rare case of
127 // severe network freezes that a higher capacity will lead to a (transient) 126 // severe network freezes that a higher capacity will lead to a (transient)
128 // increase in audio delay. 127 // increase in audio delay.
129 struct NetEqCapacityConfig { 128 struct NetEqCapacityConfig {
130 NetEqCapacityConfig() : enabled(false), capacity(0) {} 129 NetEqCapacityConfig() : enabled(false), capacity(0) {}
131 explicit NetEqCapacityConfig(int value) : enabled(true), capacity(value) {} 130 explicit NetEqCapacityConfig(int value) : enabled(true), capacity(value) {}
132 static const ConfigOptionID identifier = ConfigOptionID::kNetEqCapacityConfig;
133 bool enabled; 131 bool enabled;
134 int capacity; 132 int capacity;
135 }; 133 };
136 134
137 struct NetEqFastAccelerate { 135 struct NetEqFastAccelerate {
138 NetEqFastAccelerate() : enabled(false) {} 136 NetEqFastAccelerate() : enabled(false) {}
139 explicit NetEqFastAccelerate(bool value) : enabled(value) {} 137 explicit NetEqFastAccelerate(bool value) : enabled(value) {}
140 static const ConfigOptionID identifier = ConfigOptionID::kNetEqFastAccelerate;
141 bool enabled; 138 bool enabled;
142 }; 139 };
143 140
144 struct VoicePacing { 141 struct VoicePacing {
145 VoicePacing() : enabled(false) {} 142 VoicePacing() : enabled(false) {}
146 explicit VoicePacing(bool value) : enabled(value) {} 143 explicit VoicePacing(bool value) : enabled(value) {}
147 static const ConfigOptionID identifier = ConfigOptionID::kVoicePacing;
148 bool enabled; 144 bool enabled;
149 }; 145 };
150 146
151 } // namespace webrtc 147 } // namespace webrtc
152 148
153 #endif // WEBRTC_CONFIG_H_ 149 #endif // WEBRTC_CONFIG_H_
OLDNEW
« no previous file with comments | « webrtc/common.h ('k') | webrtc/modules/audio_processing/include/audio_processing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698