Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1581583002: Add default dummy implementation of cricket::VideoRenderer::SetSize, to easy later removal. (Closed)

Created:
4 years, 11 months ago by nisse-webrtc
Modified:
4 years, 11 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add default dummy implementation of cricket::VideoRenderer::SetSize, to easy later removal. BUG=webrtc:5426 Committed: https://crrev.com/127782bbb11da802ad2494939965cc50119ecd38 Cr-Commit-Position: refs/heads/master@{#11218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M talk/app/webrtc/videosource.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/app/webrtc/videotrackrenderers.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/videotrackrenderers.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/media/base/videorenderer.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nisse-webrtc
Related discussion on https://codereview.webrtc.org/1574963002/
4 years, 11 months ago (2016-01-12 10:05:58 UTC) #2
perkj_webrtc
On 2016/01/12 10:05:58, nisse-webrtc wrote: > Related discussion on https://codereview.webrtc.org/1574963002/ lgtm
4 years, 11 months ago (2016-01-12 10:44:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581583002/1
4 years, 11 months ago (2016-01-12 10:44:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 11:39:18 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 11:39:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/127782bbb11da802ad2494939965cc50119ecd38
Cr-Commit-Position: refs/heads/master@{#11218}

Powered by Google App Engine
This is Rietveld 408576698