Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: talk/media/base/videorenderer.h

Issue 1581583002: Add default dummy implementation of cricket::VideoRenderer::SetSize, to easy later removal. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/videotrackrenderers.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2004 Google Inc. 3 * Copyright 2004 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 24 matching lines...) Expand all
35 #include "webrtc/base/sigslot.h" 35 #include "webrtc/base/sigslot.h"
36 36
37 namespace cricket { 37 namespace cricket {
38 38
39 class VideoFrame; 39 class VideoFrame;
40 40
41 // Abstract interface for rendering VideoFrames. 41 // Abstract interface for rendering VideoFrames.
42 class VideoRenderer { 42 class VideoRenderer {
43 public: 43 public:
44 virtual ~VideoRenderer() {} 44 virtual ~VideoRenderer() {}
45 // Called when the video has changed size. This is also used as an 45 // Called when the video has changed size.
46 // initialization method to set the UI size before any video frame 46 // TODO(nisse): This method is not really used, and should be
47 // rendered. webrtc::ExternalRenderer's FrameSizeChange will invoke this when 47 // deleted. Provide a default do-nothing implementation, to easy the
48 // it's called or later when a VideoRenderer is attached. 48 // transition as the method is deleted in subclasses, in particular,
49 virtual bool SetSize(int width, int height, int reserved) = 0; 49 // chrome's MockVideoRenderer class.
50 virtual bool SetSize(int width, int height, int reserved) { return true; };
50 // Called when a new frame is available for display. 51 // Called when a new frame is available for display.
51 virtual bool RenderFrame(const VideoFrame *frame) = 0; 52 virtual bool RenderFrame(const VideoFrame *frame) = 0;
52 53
53 #if !defined(NDEBUG) 54 #if !defined(NDEBUG)
54 // Allow renderer dumping out rendered frames. 55 // Allow renderer dumping out rendered frames.
55 virtual bool SetDumpPath(const std::string &path) { return true; } 56 virtual bool SetDumpPath(const std::string &path) { return true; }
56 #endif 57 #endif
57 }; 58 };
58 59
59 } // namespace cricket 60 } // namespace cricket
60 61
61 #endif // TALK_MEDIA_BASE_VIDEORENDERER_H_ 62 #endif // TALK_MEDIA_BASE_VIDEORENDERER_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/videotrackrenderers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698