Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h

Issue 1579213007: Enable fullscreen windows to be shown in mac window share picker (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Review fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h
diff --git a/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h b/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h
index 4e6008966e6379ab06881426b2864fbd0151449a..099622f8295975d877268968a08f3fd44637d6dd 100644
--- a/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h
+++ b/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h
@@ -13,6 +13,7 @@
#include <ApplicationServices/ApplicationServices.h>
+#include "webrtc/modules/desktop_capture/mac/desktop_configuration.h"
#include "webrtc/modules/desktop_capture/window_capturer.h"
#include "webrtc/system_wrappers/include/atomic32.h"
#include "webrtc/system_wrappers/include/tick_util.h"
@@ -44,6 +45,13 @@ class FullScreenChromeWindowDetector {
// criteria are met, or kCGNullWindowID if no such window found.
CGWindowID FindFullScreenWindow(CGWindowID original_window);
+ // Returns true if the window is occupying a full screen.
+ static bool IsWindowFullScreen(const MacDesktopConfiguration& desktop_config,
+ CFDictionaryRef window);
+
+ // Returns true if the window is minimized.
+ static bool IsWindowMinimized(CGWindowID id);
Sergey Ulanov 2016/01/13 22:34:03 Maybe move this to window_list_utils.h/cc? It's no
niklas.enbom 2016/01/14 23:47:05 Makes sense, and makes the code nicer by shortenin
+
// The caller should call this function periodically, no less than twice per
// second.
void UpdateWindowListIfNeeded(CGWindowID original_window);

Powered by Google App Engine
This is Rietveld 408576698