Enable fullscreen windows to be shown in mac window share picker

webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_
 #define WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_
 
 #include <ApplicationServices/ApplicationServices.h>
 
+#include "webrtc/modules/desktop_capture/mac/desktop_configuration.h"
 #include "webrtc/modules/desktop_capture/window_capturer.h"
 #include "webrtc/system_wrappers/include/atomic32.h"
 #include "webrtc/system_wrappers/include/tick_util.h"
 
 namespace webrtc {
 
 // This is a work around for the Chrome tab full-screen behavior: Chrome
 // creates a new window in full-screen mode to show a tab full-screen and
 // minimizes the old window. To continue capturing in this case, we try to
 // find the new full-screen window using these criteria:
@@ skipping 11 matching lines @@
   void AddRef() { ++ref_count_; }
   void Release() {
     if (--ref_count_ == 0)
       delete this;
   }
 
   // Returns the full-screen window in place of the original window if all the
   // criteria are met, or kCGNullWindowID if no such window found.
   CGWindowID FindFullScreenWindow(CGWindowID original_window);
 
+  // Returns true if the window is occupying a full screen.
+  static bool IsWindowFullScreen(const MacDesktopConfiguration& desktop_config,
+                                 CFDictionaryRef window);
+
+  // Returns true if the window is minimized.
+  static bool IsWindowMinimized(CGWindowID id);

[Sergey Ulanov, 2016/01/13 22:34:03]

Maybe move this to window_list_utils.h/cc? It's not directly related to
full-screen detection.

IsWindowFullScreen() can be moved as well.

[niklas.enbom, 2016/01/14 23:47:05]

Makes sense, and makes the code nicer by shortening down the function names.

On 2016/01/13 22:34:03, Sergey Ulanov wrote:

+
   // The caller should call this function periodically, no less than twice per
   // second.
   void UpdateWindowListIfNeeded(CGWindowID original_window);
 
  private:
   ~FullScreenChromeWindowDetector();
 
   Atomic32 ref_count_;
 
   // We cache the last two results of the window list, so
   // |previous_window_list_| is taken at least 500ms before the next Capture()
   // call. If we only save the last result, we may get false positive (i.e.
   // full-screen window exists in the list) if Capture() is called too soon.
   WindowCapturer::WindowList current_window_list_;
   WindowCapturer::WindowList previous_window_list_;
   TickTime last_udpate_time_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(FullScreenChromeWindowDetector);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_