Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1579153003: Updated chromium/.gclient and sync_chromium.py to not ignore third_party/ffmpeg. (Closed)

Created:
4 years, 11 months ago by hbos
Modified:
4 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Updated chromium/.gclient and sync_chromium.py to not ignore third_party/ffmpeg. Was forgotten in this CL: https://codereview.webrtc.org/1575913003/ BUG=468365 R=kjellander@webrtc.org Committed: https://crrev.com/3235a27e7a939c18cd57bbd7af6f818a7c8b9155 Cr-Commit-Position: refs/heads/master@{#11222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chromium/.gclient View 1 chunk +0 lines, -1 line 0 comments Download
M sync_chromium.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hbos
Ples take a look kjellander
4 years, 11 months ago (2016-01-12 11:08:58 UTC) #2
kjellander_webrtc
lgtm I think I said no need to run trybots on this one...
4 years, 11 months ago (2016-01-12 12:30:50 UTC) #3
hbos
On 2016/01/12 12:30:50, kjellander (webrtc) wrote: > lgtm > > I think I said no ...
4 years, 11 months ago (2016-01-12 13:59:09 UTC) #4
hbos
Committed patchset #1 (id:1) manually as 3235a27e7a939c18cd57bbd7af6f818a7c8b9155 (presubmit successful).
4 years, 11 months ago (2016-01-12 14:05:45 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 14:05:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3235a27e7a939c18cd57bbd7af6f818a7c8b9155
Cr-Commit-Position: refs/heads/master@{#11222}

Powered by Google App Engine
This is Rietveld 408576698