Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1575913003: H.264: Default flags and pulling in openh264 and ffmpeg. (Closed)

Created:
4 years, 11 months ago by hbos
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

H.264: Default flags and pulling in openh264 and ffmpeg. Defining use_third_party_h264 directly, and indirectly defining use_openh264 (from third_party/openh264) and ffmpeg_branding (from third_party/ffmpeg). These will be used in a follow-up CL that adds an encoder and decoder implementation. The flags are added in this CL so that they can be used by trybots/waterfall bots in GN without "Build argument had no effect" errors. Equivalent GYP changes are also added. BUG=468365 Committed: https://crrev.com/a9a1d2acaf71281a6f09cd85acb6bc21b02e5ce4 Cr-Commit-Position: refs/heads/master@{#11204}

Patch Set 1 #

Patch Set 2 : Added TODO-comment to clarify flag is not correctly used yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M .gitignore View 2 chunks +2 lines, -0 lines 0 comments Download
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M setup_links.py View 2 chunks +2 lines, -0 lines 0 comments Download
M sync_chromium.py View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/common.gypi View 1 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
hbos
Please take a look, kjelle. Because the use_openh264 and ffmpeg_branding variables are defined in third_party/... ...
4 years, 11 months ago (2016-01-11 13:31:48 UTC) #2
hbos
On 2016/01/11 13:31:48, hbos wrote: > Please take a look, kjelle. > > Because the ...
4 years, 11 months ago (2016-01-11 13:34:52 UTC) #3
kjellander_webrtc
lgtm. Make sure we run all trybots for this one, just to be sure.
4 years, 11 months ago (2016-01-11 13:42:37 UTC) #4
hbos
On 2016/01/11 13:42:37, kjellander (webrtc) wrote: > lgtm. Make sure we run all trybots for ...
4 years, 11 months ago (2016-01-11 13:49:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575913003/20001
4 years, 11 months ago (2016-01-11 13:49:54 UTC) #7
kjellander_webrtc
On 2016/01/11 13:49:40, hbos wrote: > On 2016/01/11 13:42:37, kjellander (webrtc) wrote: > > lgtm. ...
4 years, 11 months ago (2016-01-11 14:07:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 11 months ago (2016-01-11 15:50:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575913003/20001
4 years, 11 months ago (2016-01-11 18:15:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 18:19:07 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a9a1d2acaf71281a6f09cd85acb6bc21b02e5ce4 Cr-Commit-Position: refs/heads/master@{#11204}
4 years, 11 months ago (2016-01-11 18:19:10 UTC) #15
kjellander_webrtc
On 2016/01/11 18:19:10, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 11 months ago (2016-01-12 10:27:59 UTC) #16
hbos
4 years, 11 months ago (2016-01-12 10:48:30 UTC) #17
Message was sent while issue was closed.
On 2016/01/12 10:27:59, kjellander (webrtc) wrote:
> On 2016/01/11 18:19:10, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/a9a1d2acaf71281a6f09cd85acb6bc21b02e5ce4
> > Cr-Commit-Position: refs/heads/master@{#11204}
> 
> doh, I missed the fact that you didn't remove ffmpeg from custom_deps in
> chromium/.gclient in this CL.
> 
> Can you make another CL for that + increment SCRIPT_VERSION in
sync_chromium.py?

No idea how I missed that, I'll create a CL.

Powered by Google App Engine
This is Rietveld 408576698