Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 1578463002: Fix return type to be void. (Closed)

Created:
5 years ago by Dmitry Skiba
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix return type to be void. Missing return type causes warning (which is treated as an error) when compiling with Clang. BUG=chromium:539781 R=rtoy@google.com Committed: https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax/+/6670e52d32351145a6b6c198dab3f6a536edf3db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dl/sp/src/arm/arm64/omxSP_FFTInv_CCSToR_F32.c View 1 chunk +1 line, -1 line 0 comments Download
M dl/sp/src/arm/arm64/omxSP_FFTInv_CToC_FC32.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Dmitry Skiba
5 years ago (2016-01-08 22:55:07 UTC) #2
Raymond Toy (Google)
lgtm
5 years ago (2016-01-08 23:15:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578463002/1
5 years ago (2016-01-08 23:16:11 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years ago (2016-01-08 23:16:13 UTC) #8
Raymond Toy (Google)
On 2016/01/08 23:16:13, commit-bot: I haz the power wrote: > CLs for remote refs other ...
5 years ago (2016-01-08 23:24:13 UTC) #9
Dmitry Skiba
On 2016/01/08 23:24:13, Raymond Toy (Google) wrote: > On 2016/01/08 23:16:13, commit-bot: I haz the ...
5 years ago (2016-01-08 23:27:05 UTC) #10
Raymond Toy (Google)
5 years ago (2016-01-08 23:27:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6670e52d32351145a6b6c198dab3f6a536edf3db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698