[rtp_rtcp] Added structure to use as item in TMMBN/TMMBR

rtcp::TmmbItem designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::TmmbItem> will replace TMMBRSet class for storage, processing and preparing TMBBR/TMMBN
(i.e. this TmmbItem replaces Timber structure introduced in https://codereview.webrtc.org/1474693002 )
Previous structures store bitrate in kbps. TmmbItem use bps removing need to regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/a92d6be4111c4b1d3876093ee46bc8713dad5f7f
Cr-Commit-Position: refs/heads/master@{#11491}

[danilchap, 2016-01-15 19:08:18]

Description was changed from

==========
[rtp_rtcp] Added structure used as item in TMMBN/TMMBR

rtcp::Timber would replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for creating
and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::Timber> would replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this Timber replaces Timber structure introduced in CL#1474693002)
Note: previous structures stored bitrate in kbps. Timber use bps removing need
to regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
[rtp_rtcp] Added structure to use as item in TMMBN/TMMBR

rtcp::Timber designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::Timber> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this Timber replaces Timber structure introduced in CL#1474693002)
Previous structures store bitrate in kbps. Timber use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

[danilchap, 2016-01-15 19:08:46]

Description was changed from

==========
[rtp_rtcp] Added structure to use as item in TMMBN/TMMBR

rtcp::Timber designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::Timber> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this Timber replaces Timber structure introduced in CL#1474693002)
Previous structures store bitrate in kbps. Timber use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::Timber designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::Timber> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this Timber replaces Timber structure introduced in CL#1474693002)
Previous structures store bitrate in kbps. Timber use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

[åsapersson, 2016-02-04 13:39:31]

https://codereview.webrtc.org/1576223003/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/timber.h (right):

https://codereview.webrtc.org/1576223003/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/timber.h:19: // Timber is
human-friendly name for TMMBR:
I think i would prefer this to be called TmmbrItem or TmmbrRequest or similar.

[danilchap, 2016-02-04 14:08:37]

https://codereview.webrtc.org/1576223003/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/timber.h (right):

https://codereview.webrtc.org/1576223003/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_packet/timber.h:19: // Timber is
human-friendly name for TMMBR:
On 2016/02/04 13:39:31, åsapersson wrote:
> I think i would prefer this to be called TmmbrItem or TmmbrRequest or similar.

It can be used both as request and notification, i.e. both in Tmmbr and Tmmbn
packets. How about TmmbItem?

[åsapersson, 2016-02-04 14:23:39]

On 2016/02/04 14:08:37, danilchap wrote:
>
https://codereview.webrtc.org/1576223003/diff/60001/webrtc/modules/rtp_rtcp/s...
> File webrtc/modules/rtp_rtcp/source/rtcp_packet/timber.h (right):
> 
>
https://codereview.webrtc.org/1576223003/diff/60001/webrtc/modules/rtp_rtcp/s...
> webrtc/modules/rtp_rtcp/source/rtcp_packet/timber.h:19: // Timber is
> human-friendly name for TMMBR:
> On 2016/02/04 13:39:31, åsapersson wrote:
> > I think i would prefer this to be called TmmbrItem or TmmbrRequest or
similar.
> 
> It can be used both as request and notification, i.e. both in Tmmbr and Tmmbn
> packets. How about TmmbItem?

lgtm

please update description with change

[danilchap, 2016-02-04 14:25:34]

Description was changed from

==========
rtcp::Timber designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::Timber> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this Timber replaces Timber structure introduced in CL#1474693002)
Previous structures store bitrate in kbps. Timber use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::TmmbItem designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::TmmbItem> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this TmmbItem replaces Timber structure introduced in
https://codereview.webrtc.org/1474693002 )
Previous structures store bitrate in kbps. Timber use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

[danilchap, 2016-02-04 14:26:05]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-02-04 14:26:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576223003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576223003/80001

[danilchap, 2016-02-04 14:26:50]

Description was changed from

==========
rtcp::TmmbItem designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::TmmbItem> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this TmmbItem replaces Timber structure introduced in
https://codereview.webrtc.org/1474693002 )
Previous structures store bitrate in kbps. Timber use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::TmmbItem designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::TmmbItem> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this TmmbItem replaces Timber structure introduced in
https://codereview.webrtc.org/1474693002 )
Previous structures store bitrate in kbps. TmmbItem use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

[commit-bot: I haz the power, 2016-02-04 15:33:42]

Description was changed from

==========
rtcp::TmmbItem designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::TmmbItem> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this TmmbItem replaces Timber structure introduced in
https://codereview.webrtc.org/1474693002 )
Previous structures store bitrate in kbps. TmmbItem use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::TmmbItem designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::TmmbItem> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this TmmbItem replaces Timber structure introduced in
https://codereview.webrtc.org/1474693002 )
Previous structures store bitrate in kbps. TmmbItem use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

[commit-bot: I haz the power, 2016-02-04 15:33:43]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-04 15:33:47]

Description was changed from

==========
rtcp::TmmbItem designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::TmmbItem> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this TmmbItem replaces Timber structure introduced in
https://codereview.webrtc.org/1474693002 )
Previous structures store bitrate in kbps. TmmbItem use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::TmmbItem designed to replace RTCPUtility::RTCPPacketRTPFBTMMBRItem (for
creating and parsing rtcp TMMBR/TMMBN packets)
std::vector<rtcp::TmmbItem> will replace TMMBRSet class for storage, processing
and preparing TMBBR/TMMBN
(i.e. this TmmbItem replaces Timber structure introduced in
https://codereview.webrtc.org/1474693002 )
Previous structures store bitrate in kbps. TmmbItem use bps removing need to
regularly divide and multiply by 1000.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/a92d6be4111c4b1d3876093ee46bc8713dad5f7f
Cr-Commit-Position: refs/heads/master@{#11491}
==========

[commit-bot: I haz the power, 2016-02-04 15:33:48]

Patchset 5 (id:??) landed as
https://crrev.com/a92d6be4111c4b1d3876093ee46bc8713dad5f7f
Cr-Commit-Position: refs/heads/master@{#11491}