Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1474693002: [Splitting] TMMBRHelp class simplifted (and disappear because become too simple) (Closed)

Created:
5 years ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, pbos-webrtc, sprang_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

TMMBRHelp class simplifted (and disappear because become too simple): TMMBRSet class replaced with a vector TMMBRHelp Members are removed because almost all of them are used as temporary variables. All TMMBRHelp functions except one are used just once and they become too trivial to keep them as dedicated functions. RtcpSender/RtcpReceiver were slightly simplified because of change in TMMBRHelp. BUG=webrtc:5260, webrtc:951

Patch Set 1 #

Patch Set 2 : fixed lint error in tmmbr_help #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase & make use of TmmbItem #

Patch Set 6 : rebase & fix division by zero #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -793 lines) Patch
M webrtc/modules/rtp_rtcp/source/CPPLINT.cfg View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 2 3 4 5 6 7 1 chunk +180 lines, -184 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 2 3 4 5 6 7 7 chunks +39 lines, -79 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc View 1 2 3 4 5 6 7 2 chunks +26 lines, -36 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 2 3 4 5 6 7 5 chunks +13 lines, -19 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 2 3 4 5 6 7 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 3 4 5 6 7 6 chunks +20 lines, -24 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -70 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.cc View 1 2 3 4 5 6 7 1 chunk +97 lines, -361 lines 0 comments Download

Messages

Total messages: 15 (12 generated)
danilchap
5 years ago (2015-11-24 14:01:05 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474693002/1
5 years ago (2015-11-26 15:13:23 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-26 17:13:45 UTC) #8
Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

Powered by Google App Engine
This is Rietveld 408576698