webrtc/modules/rtp_rtcp/source/rtcp_sender.h - Issue 1474693002: [Splitting] TMMBRHelp class simplifted (and disappear because become too simple)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

Issue 1474693002: [Splitting] TMMBRHelp class simplifted (and disappear because become too simple) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

index 02719aa1c50907d549a40afd71d1905898194963..5b9678093b88fbd57d8a27d13bc15948831e6d0f 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

@@ -240,11 +240,9 @@ class RTCPSender {

uint32_t remb_bitrate_ GUARDED_BY(critical_section_rtcp_sender_);

std::vector<uint32_t> remb_ssrcs_ GUARDED_BY(critical_section_rtcp_sender_);

- TMMBRHelp tmmbr_help_ GUARDED_BY(critical_section_rtcp_sender_);

std::vector<rtcp::TmmbItem> tmmbn_to_send_

GUARDED_BY(critical_section_rtcp_sender_);

- uint32_t tmmbr_send_ GUARDED_BY(critical_section_rtcp_sender_);

- uint32_t packet_oh_send_ GUARDED_BY(critical_section_rtcp_sender_);

+ rtcp::TmmbItem tmmbr_to_send_ GUARDED_BY(critical_section_rtcp_sender_);

size_t max_payload_length_;

// APP

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_sender.cc » ('j') | no next file with comments »