H.264: Default flags and pulling in openh264 and ffmpeg.

H.264: Default flags and pulling in openh264 and ffmpeg.

Defining use_third_party_h264 directly, and indirectly defining use_openh264 (from third_party/openh264) and ffmpeg_branding (from third_party/ffmpeg).
These will be used in a follow-up CL that adds an encoder and decoder implementation.
The flags are added in this CL so that they can be used by trybots/waterfall bots in GN without "Build argument had no effect" errors. Equivalent GYP changes are also added.

BUG=468365
Committed: https://crrev.com/a9a1d2acaf71281a6f09cd85acb6bc21b02e5ce4
Cr-Commit-Position: refs/heads/master@{#11204}

[hbos, 2016-01-11 13:31:48]

hbos@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[hbos, 2016-01-11 13:31:48]

Please take a look, kjelle.

Because the use_openh264 and ffmpeg_branding variables are defined in
third_party/... I don't think I can do a trybot run as if all flags are set.
I tried setting all variables locally though (for both GYP and GN) and it should
be fine because they're not very much used in this CL, just there to be defined.

[hbos, 2016-01-11 13:34:52]

On 2016/01/11 13:31:48, hbos wrote:
> Please take a look, kjelle.
> 
> Because the use_openh264 and ffmpeg_branding variables are defined in
> third_party/... I don't think I can do a trybot run as if all flags are set.
> I tried setting all variables locally though (for both GYP and GN) and it
should
> be fine because they're not very much used in this CL, just there to be
defined.

What I mean is the variable I can change the default of to true in this repo is
use_third_party_h264, but without also overriding use_openh264 and
ffmpeg_branding it will not compile. So only trybotting with default false. But
these flags should have no "real" effect in this CL anyway and it works locally.

[kjellander_webrtc, 2016-01-11 13:42:37]

lgtm. Make sure we run all trybots for this one, just to be sure.

[hbos, 2016-01-11 13:49:40]

On 2016/01/11 13:42:37, kjellander (webrtc) wrote:
> lgtm. Make sure we run all trybots for this one, just to be sure.

Yes (though unfortunately the trybots don't say what happens when all three
flags are switched to true).

[hbos, 2016-01-11 13:49:46]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-01-11 13:49:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1575913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1575913003/20001

[kjellander_webrtc, 2016-01-11 14:07:50]

On 2016/01/11 13:49:40, hbos wrote:
> On 2016/01/11 13:42:37, kjellander (webrtc) wrote:
> > lgtm. Make sure we run all trybots for this one, just to be sure.
> 
> Yes (though unfortunately the trybots don't say what happens when all three
> flags are switched to true).

Yeah, but there can be other errors too!

[commit-bot: I haz the power, 2016-01-11 15:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 15:50:14]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hbos_chromium, 2016-01-11 18:14:56]

The CQ bit was checked by hbos@chromium.org

[commit-bot: I haz the power, 2016-01-11 18:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1575913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1575913003/20001

[commit-bot: I haz the power, 2016-01-11 18:19:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-11 18:19:09]

Description was changed from

==========
H.264: Default flags and pulling in openh264 and ffmpeg.

Defining use_third_party_h264 directly, and indirectly defining use_openh264
(from third_party/openh264) and ffmpeg_branding (from third_party/ffmpeg).
These will be used in a follow-up CL that adds an encoder and decoder
implementation.
The flags are added in this CL so that they can be used by trybots/waterfall
bots in GN without "Build argument had no effect" errors. Equivalent GYP changes
are also added.

BUG=468365
==========

to

==========
H.264: Default flags and pulling in openh264 and ffmpeg.

Defining use_third_party_h264 directly, and indirectly defining use_openh264
(from third_party/openh264) and ffmpeg_branding (from third_party/ffmpeg).
These will be used in a follow-up CL that adds an encoder and decoder
implementation.
The flags are added in this CL so that they can be used by trybots/waterfall
bots in GN without "Build argument had no effect" errors. Equivalent GYP changes
are also added.

BUG=468365

Committed: https://crrev.com/a9a1d2acaf71281a6f09cd85acb6bc21b02e5ce4
Cr-Commit-Position: refs/heads/master@{#11204}
==========

[commit-bot: I haz the power, 2016-01-11 18:19:10]

Patchset 2 (id:??) landed as
https://crrev.com/a9a1d2acaf71281a6f09cd85acb6bc21b02e5ce4
Cr-Commit-Position: refs/heads/master@{#11204}

[kjellander_webrtc, 2016-01-12 10:27:59]

On 2016/01/11 18:19:10, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/a9a1d2acaf71281a6f09cd85acb6bc21b02e5ce4
> Cr-Commit-Position: refs/heads/master@{#11204}

doh, I missed the fact that you didn't remove ffmpeg from custom_deps in
chromium/.gclient in this CL.

Can you make another CL for that + increment SCRIPT_VERSION in sync_chromium.py?

[hbos, 2016-01-12 10:48:30]

On 2016/01/12 10:27:59, kjellander (webrtc) wrote:
> On 2016/01/11 18:19:10, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/a9a1d2acaf71281a6f09cd85acb6bc21b02e5ce4
> > Cr-Commit-Position: refs/heads/master@{#11204}
> 
> doh, I missed the fact that you didn't remove ffmpeg from custom_deps in
> chromium/.gclient in this CL.
> 
> Can you make another CL for that + increment SCRIPT_VERSION in
sync_chromium.py?

No idea how I missed that, I'll create a CL.