Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1573453002: Add CreateSend/ReceiveTransport() methods to CallTest. (Closed)

Created:
4 years, 11 months ago by stefan-webrtc
Modified:
4 years, 11 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman, the sun, pbos-webrtc, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add CreateSend/ReceiveTransport() methods to CallTest. This allows the test to create its own transports if it, for instance, needs to do demuxing. BUG=webrtc:5416 Committed: https://crrev.com/e74eef19bd3f101208dc72b98038e42fc523a351 Cr-Commit-Position: refs/heads/master@{#11187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -101 lines) Patch
M webrtc/call/call_perf_tests.cc View 7 chunks +16 lines, -6 lines 0 comments Download
M webrtc/call/rampup_tests.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/call/rampup_tests.cc View 2 chunks +26 lines, -26 lines 0 comments Download
M webrtc/test/call_test.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/test/call_test.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 23 chunks +38 lines, -28 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 20 chunks +28 lines, -27 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
stefan-webrtc
4 years, 11 months ago (2016-01-08 12:49:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573453002/1
4 years, 11 months ago (2016-01-08 12:49:35 UTC) #4
pbos-webrtc
lgtm
4 years, 11 months ago (2016-01-08 13:03:35 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 13:49:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573453002/1
4 years, 11 months ago (2016-01-08 14:46:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 14:47:17 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 14:47:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e74eef19bd3f101208dc72b98038e42fc523a351
Cr-Commit-Position: refs/heads/master@{#11187}

Powered by Google App Engine
This is Rietveld 408576698