Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: webrtc/test/call_test.cc

Issue 1573453002: Add CreateSend/ReceiveTransport() methods to CallTest. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/call_test.h ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/call_test.cc
diff --git a/webrtc/test/call_test.cc b/webrtc/test/call_test.cc
index 83fd844db90bba2fcef6de84e98d67e605985cc6..850e487caf9d5f10219ad1695dda7fe8e74acad0 100644
--- a/webrtc/test/call_test.cc
+++ b/webrtc/test/call_test.cc
@@ -39,8 +39,7 @@ CallTest::CallTest()
CallTest::~CallTest() {
}
-void CallTest::RunBaseTest(BaseTest* test,
- const FakeNetworkPipe::Config& config) {
+void CallTest::RunBaseTest(BaseTest* test) {
num_video_streams_ = test->GetNumVideoStreams();
num_audio_streams_ = test->GetNumAudioStreams();
RTC_DCHECK(num_video_streams_ > 0 || num_audio_streams_ > 0);
@@ -61,11 +60,8 @@ void CallTest::RunBaseTest(BaseTest* test,
}
CreateReceiverCall(recv_config);
}
- send_transport_.reset(new PacketTransport(
- sender_call_.get(), test, test::PacketTransport::kSender, config));
- receive_transport_.reset(new PacketTransport(
- nullptr, test, test::PacketTransport::kReceiver, config));
- test->OnTransportsCreated(send_transport_.get(), receive_transport_.get());
+ send_transport_.reset(test->CreateSendTransport(sender_call_.get()));
+ receive_transport_.reset(test->CreateReceiveTransport());
test->OnCallsCreated(sender_call_.get(), receiver_call_.get());
if (test->ShouldCreateReceivers()) {
@@ -384,8 +380,15 @@ Call::Config BaseTest::GetReceiverCallConfig() {
void BaseTest::OnCallsCreated(Call* sender_call, Call* receiver_call) {
}
-void BaseTest::OnTransportsCreated(PacketTransport* send_transport,
- PacketTransport* receive_transport) {}
+test::PacketTransport* BaseTest::CreateSendTransport(Call* sender_call) {
+ return new PacketTransport(sender_call, this, test::PacketTransport::kSender,
+ FakeNetworkPipe::Config());
+}
+
+test::PacketTransport* BaseTest::CreateReceiveTransport() {
+ return new PacketTransport(nullptr, this, test::PacketTransport::kReceiver,
+ FakeNetworkPipe::Config());
+}
size_t BaseTest::GetNumVideoStreams() const {
return 1;
« no previous file with comments | « webrtc/test/call_test.h ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698