Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1571853002: SCTP: Stopped accepting SSRCs higher than max. (Closed)

Created:
4 years, 11 months ago by lally
Modified:
4 years, 11 months ago
Reviewers:
pthatcher1, Lally Singh
CC:
webrtc-reviews_webrtc.org, pthatcher
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

SCTP: Stopped accepting SSRCs higher than max. Seems to fix asan-related crash. BUG=https://code.google.com/p/chromium/issues/detail?id=570261 Committed: https://crrev.com/27ed3cc28cf950456a0c66d7a10656a96832fedd Cr-Commit-Position: refs/heads/master@{#11205}

Patch Set 1 #

Patch Set 2 : Added a simple unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M talk/media/sctp/sctpdataengine.cc View 1 chunk +7 lines, -1 line 0 comments Download
M talk/media/sctp/sctpdataengine_unittest.cc View 1 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
lally
PTAL, thanks.
4 years, 11 months ago (2016-01-08 18:52:24 UTC) #3
pthatcher1
Good catch and fix. But can we add a simple unit test? And any idea ...
4 years, 11 months ago (2016-01-08 20:19:36 UTC) #4
lally
On 2016/01/08 20:19:36, pthatcher1 wrote: > Good catch and fix. > > But can we ...
4 years, 11 months ago (2016-01-08 21:14:46 UTC) #5
lally
On 2016/01/08 21:14:46, lally wrote: > On 2016/01/08 20:19:36, pthatcher1 wrote: > > Good catch ...
4 years, 11 months ago (2016-01-08 21:25:55 UTC) #6
pthatcher1
lgtm
4 years, 11 months ago (2016-01-08 21:43:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571853002/20001
4 years, 11 months ago (2016-01-11 15:52:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 18:24:36 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 18:24:43 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27ed3cc28cf950456a0c66d7a10656a96832fedd
Cr-Commit-Position: refs/heads/master@{#11205}

Powered by Google App Engine
This is Rietveld 408576698