Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: talk/media/sctp/sctpdataengine_unittest.cc

Issue 1571853002: SCTP: Stopped accepting SSRCs higher than max. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added a simple unit test. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/sctp/sctpdataengine.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/sctp/sctpdataengine_unittest.cc
diff --git a/talk/media/sctp/sctpdataengine_unittest.cc b/talk/media/sctp/sctpdataengine_unittest.cc
index 4706368b9d3ca2657a40f937da8160f37b7c008e..d673c69c98e9cd7606c2748f4adf2298510a2afc 100644
--- a/talk/media/sctp/sctpdataengine_unittest.cc
+++ b/talk/media/sctp/sctpdataengine_unittest.cc
@@ -270,12 +270,14 @@ class SctpDataMediaChannelTest : public testing::Test,
ProcessMessagesUntilIdle();
}
- void AddStream(int ssrc) {
+ bool AddStream(int ssrc) {
+ bool ret = true;
cricket::StreamParams p(cricket::StreamParams::CreateLegacy(ssrc));
- chan1_->AddSendStream(p);
- chan1_->AddRecvStream(p);
- chan2_->AddSendStream(p);
- chan2_->AddRecvStream(p);
+ ret = ret && chan1_->AddSendStream(p);
+ ret = ret && chan1_->AddRecvStream(p);
+ ret = ret && chan2_->AddSendStream(p);
+ ret = ret && chan2_->AddRecvStream(p);
+ return ret;
}
cricket::SctpDataMediaChannel* CreateChannel(
@@ -504,6 +506,12 @@ TEST_F(SctpDataMediaChannelTest, EngineSignalsRightChannel) {
EXPECT_GT(channel1_ready_to_send_count(), prior_count);
}
+TEST_F(SctpDataMediaChannelTest, RefusesHighNumberedChannels) {
+ SetupConnectedChannels();
+ EXPECT_TRUE(AddStream(1022));
+ EXPECT_FALSE(AddStream(1023));
+}
+
// Flaky on Linux and Windows. See webrtc:4453.
#if defined(WEBRTC_WIN) || defined(WEBRTC_LINUX)
#define MAYBE_ReusesAStream DISABLED_ReusesAStream
« no previous file with comments | « talk/media/sctp/sctpdataengine.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698