Fixes a bug which incorrectly logs incoming RTCP as outgoing.

webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index 6a7022a94cc66bda08f0749b1c1761b0d7da1b08..d9d03e686b7245934f50b0f9bc13984f1f8258e2 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -24,6 +24,8 @@ class ReceiveStatistics;
 class RemoteBitrateEstimator;
 class RtpReceiver;
 class Transport;
+class RtcEventLog;
+
 namespace rtcp {
 class TransportFeedback;
 }
@@ -73,6 +75,9 @@ class RtpRtcp : public Module {
     BitrateStatisticsObserver* send_bitrate_observer;
     FrameCountObserver* send_frame_count_observer;
     SendSideDelayObserver* send_side_delay_observer;
+    RtcEventLog* event_log;
+
+    RTC_DISALLOW_COPY_AND_ASSIGN(Configuration);

[the sun, 2016/01/11 15:59:57]

This is a POD, right? Unless it owns any of these resources it makes sense for
it to be copyable/assignable.

[terelius, 2016/01/11 18:39:47]

Not sure it is technically POD since the constructor calls
NullObjectReceiveStatistics and NullObjectRtpAudioFeedback. However, for all
practical purposes it should behave as a POD structure and the default copy
constructor should be fine.

I removed the operations mostly because of your
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS suggestion. Copying the configuration struct
used to construct an RTPSender would have a similar effect to copying an
RTPSender. In particular, both senders would use the same bitrate estimator,
RTCP stats and event log etc and there might be race conditions since the
Senders would have separate locks protecting the same data.

I don't have a strong opinion on this, but I think it makes sense to remove copy
and assignment.

[the sun, 2016/01/12 12:05:21]

Acknowledged.

   };
 
   /*