Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added RTC_DISALLOW_IMPLICT_CONSTRUCTORS Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h
index dd3aec4c9fa75eab0b1b6738825065a95c44dfff..0408e3e99c3a0a7caec621b1590121454b1d8a3d 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h
@@ -35,6 +35,7 @@ namespace webrtc {
class ModuleRtpRtcpImpl;
class RTCPReceiver;
+class RtcEventLog;
class NACKStringBuilder {
public:
@@ -77,6 +78,7 @@ class RTCPSender {
Clock* clock,
ReceiveStatistics* receive_statistics,
RtcpPacketTypeCounterObserver* packet_type_counter_observer,
+ RtcEventLog* event_log,
Transport* outgoing_transport);
virtual ~RTCPSender();
@@ -203,6 +205,7 @@ class RTCPSender {
Random random_ GUARDED_BY(critical_section_rtcp_sender_);
RtcpMode method_ GUARDED_BY(critical_section_rtcp_sender_);
+ RtcEventLog* event_log_;
the sun 2016/01/11 15:59:57 Still missing * const, or can the event_log pointe
terelius 2016/01/11 18:39:47 Done.
Transport* const transport_;
rtc::scoped_ptr<CriticalSectionWrapper> critical_section_rtcp_sender_;
@@ -296,6 +299,8 @@ class RTCPSender {
typedef rtc::scoped_ptr<rtcp::RtcpPacket> (RTCPSender::*BuilderFunc)(
const RtcpContext&);
std::map<RTCPPacketType, BuilderFunc> builders_;
+
+ RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RTCPSender);
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698