Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1565093002:
Roll chromium_revision 2a70cb1..4662d4f (367468:368042) (Closed)
|
Created:
4 years, 11 months ago by kjellander_webrtc Modified:
4 years, 11 months ago Reviewers:
henrika_webrtc CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision 2a70cb1..4662d4f (367468:368042)
I had to fix the audio_device BUILD.gn which was forgotten back
in https://codereview.webrtc.org/1536923003. It also contained a few
missing source files and one library.
Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f
Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f
Changed dependencies:
* src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4
* src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebfcc9a
DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS
No update to Clang.
TBR=henrika@webrtc.org
NOTRY=True
Committed: https://crrev.com/a46a4c92d0c74fab0028170d0746e2670160aefd
Cr-Commit-Position: refs/heads/master@{#11162}
Patch Set 1 #Patch Set 2 : Update audio_device BUILD.gn file #
Total comments: 4
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565093002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/7942)
Description was changed from ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR= ========== to ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/build/confi... turned on a Clang warning discovering some unreferenced code. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR= ==========
Description was changed from ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/build/confi... turned on a Clang warning discovering some unreferenced code. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR= ========== to ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR= ==========
kjellander@webrtc.org changed reviewers: + henrika@webrtc.org
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR= ========== to ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR=henrika@webrtc.org ==========
PTAL I'm submitting this now to avoid another breakage for the next import run that triggers in 11 minutes. https://codereview.webrtc.org/1565093002/diff/40001/webrtc/modules/audio_devi... File webrtc/modules/audio_device/BUILD.gn (right): https://codereview.webrtc.org/1565093002/diff/40001/webrtc/modules/audio_devi... webrtc/modules/audio_device/BUILD.gn:69: "android/build_info.cc", build_info.* was also missing. We need to keep these in sync when adding new code! https://codereview.webrtc.org/1565093002/diff/40001/webrtc/modules/audio_devi... webrtc/modules/audio_device/BUILD.gn:78: "OpenSLES", This was missing and was causing the compilation failure. https://codereview.webrtc.org/1565093002/diff/40001/webrtc/modules/audio_devi... webrtc/modules/audio_device/BUILD.gn:128: "ios/audio_device_not_implemented_ios.mm", This file was also missing. https://codereview.webrtc.org/1565093002/diff/40001/webrtc/modules/audio_devi... webrtc/modules/audio_device/BUILD.gn:135: "UIKit.framework", Finally this lib was missing in the GN build.
Description was changed from ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR=henrika@webrtc.org ========== to ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR=henrika@webrtc.org NOTRY=True ==========
On 2016/01/07 09:43:11, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_gn_dbg on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/7942) This is fixed in PS#2 but I'm ignoring mac_baremetal since it's a flake reported in https://bugs.chromium.org/p/webrtc/issues/detail?id=5406.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565093002/40001
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR=henrika@webrtc.org NOTRY=True ========== to ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR=henrika@webrtc.org NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR=henrika@webrtc.org NOTRY=True ========== to ========== Roll chromium_revision 2a70cb1..4662d4f (367468:368042) I had to fix the audio_device BUILD.gn which was forgotten back in https://codereview.webrtc.org/1536923003. It also contained a few missing source files and one library. Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4 * src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebf... DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS No update to Clang. TBR=henrika@webrtc.org NOTRY=True Committed: https://crrev.com/a46a4c92d0c74fab0028170d0746e2670160aefd Cr-Commit-Position: refs/heads/master@{#11162} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a46a4c92d0c74fab0028170d0746e2670160aefd Cr-Commit-Position: refs/heads/master@{#11162}
Message was sent while issue was closed.
LGTM |
