Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1536923003: audio_device: Move sources into platform-conditions. (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

audio_device: Move sources into platform-conditions. This should solve a problem discovered when converting from GYP to other project formats, where the source files weren't included correctly for each platform. Two other targets in WebRTC have similar source files, which are correctly generated for each platform: * video_render_module_internal_impl * video_capture_module_internal_impl They both list the sources as it's changed to in this CL. NOTRY=True Committed: https://crrev.com/6c6510afad45baf73850818b4ff660563d7726a5 Cr-Commit-Position: refs/heads/master@{#11083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -37 lines) Patch
M webrtc/modules/audio_device/audio_device.gypi View 5 chunks +47 lines, -37 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander_webrtc
(ignore the iOS GN bots, they're failing because GN is not yet building on iOS, ...
5 years ago (2015-12-18 11:48:52 UTC) #2
henrika_webrtc
Can you add some more details on what the actual problem is here. Not sure ...
5 years ago (2015-12-18 11:54:41 UTC) #3
kjellander_webrtc
On 2015/12/18 11:54:41, henrika_webrtc wrote: > Can you add some more details on what the ...
5 years ago (2015-12-18 12:26:21 UTC) #6
henrika_webrtc
LGTM
5 years ago (2015-12-18 12:27:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536923003/1
5 years ago (2015-12-18 12:32:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 12:33:31 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-18 12:33:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c6510afad45baf73850818b4ff660563d7726a5
Cr-Commit-Position: refs/heads/master@{#11083}

Powered by Google App Engine
This is Rietveld 408576698