Check the mic volume only periodically on Mac.

Check the mic volume only periodically on Mac.

Ask the OS for the mic volume every 1 second rather than with every 10
ms chunk. The previous behavior was consuming ~2% of the CPU load of
a voice engine call, and is now negligible.

This is consistent with the webrtc Windows Core Audio implementation,
as well as the Chromium Mac implementation:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/agc_audio_stream.h

TEST=voe_cmd_test with AGC continues to work well on Mac.

Committed: https://crrev.com/ec80f03b3cd919614d82ba70837de87718e1c4a7
Cr-Commit-Position: refs/heads/master@{#11182}

[Andrew MacDonald, 2016-01-08 00:56:59]

Description was changed from

==========
Check the mic volume only periodically on Mac.

Ask the OS for the mic volume every 1 second rather than with every 10
ms chunk. The previous behavior was consuming ~2% of the CPU load of
a voice engine call, and is now negligible.

This is consistent with the webrtc Windows Core Audio implementation,
as well as the Chromium Mac implementation:
https://cs.chromium.org/codesearch#chromium/src/media/audio/agc_audio_stream....

TEST=voe_cmd_test with AGC continues to work well on Mac.
==========

to

==========
Check the mic volume only periodically on Mac.

Ask the OS for the mic volume every 1 second rather than with every 10
ms chunk. The previous behavior was consuming ~2% of the CPU load of
a voice engine call, and is now negligible.

This is consistent with the webrtc Windows Core Audio implementation,
as well as the Chromium Mac implementation:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/agc_au...

TEST=voe_cmd_test with AGC continues to work well on Mac.
==========

[Andrew MacDonald, 2016-01-08 00:57:23]

andrew@webrtc.org changed reviewers:
+ henrika@webrtc.org

[henrika_webrtc, 2016-01-08 08:14:42]

Glad to see that you are making improvements in this area Andrew ;-)

LGTM

https://codereview.webrtc.org/1564223002/diff/1/webrtc/modules/audio_device/m...
File webrtc/modules/audio_device/mac/audio_device_mac.cc (right):

https://codereview.webrtc.org/1564223002/diff/1/webrtc/modules/audio_device/m...
webrtc/modules/audio_device/mac/audio_device_mac.cc:3187: // Use mod to ensure
we check the volume on the first pass.
Out indentation kind of sucks but I guess we should change it in the complete
file and not just where we make changes. Just an idea.

[Andrew MacDonald, 2016-01-08 08:22:10]

https://codereview.webrtc.org/1564223002/diff/1/webrtc/modules/audio_device/m...
File webrtc/modules/audio_device/mac/audio_device_mac.cc (right):

https://codereview.webrtc.org/1564223002/diff/1/webrtc/modules/audio_device/m...
webrtc/modules/audio_device/mac/audio_device_mac.cc:3187: // Use mod to ensure
we check the volume on the first pass.
On 2016/01/08 08:14:42, henrika_webrtc wrote:
> Out indentation kind of sucks but I guess we should change it in the complete
> file and not just where we make changes. Just an idea.
:)

I can run clang-format on these files in a follow-up CL.

[Andrew MacDonald, 2016-01-08 08:22:15]

The CQ bit was checked by andrew@webrtc.org

[commit-bot: I haz the power, 2016-01-08 08:22:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564223002/1

[commit-bot: I haz the power, 2016-01-08 09:16:20]

Description was changed from

==========
Check the mic volume only periodically on Mac.

Ask the OS for the mic volume every 1 second rather than with every 10
ms chunk. The previous behavior was consuming ~2% of the CPU load of
a voice engine call, and is now negligible.

This is consistent with the webrtc Windows Core Audio implementation,
as well as the Chromium Mac implementation:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/agc_au...

TEST=voe_cmd_test with AGC continues to work well on Mac.
==========

to

==========
Check the mic volume only periodically on Mac.

Ask the OS for the mic volume every 1 second rather than with every 10
ms chunk. The previous behavior was consuming ~2% of the CPU load of
a voice engine call, and is now negligible.

This is consistent with the webrtc Windows Core Audio implementation,
as well as the Chromium Mac implementation:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/agc_au...

TEST=voe_cmd_test with AGC continues to work well on Mac.
==========

[commit-bot: I haz the power, 2016-01-08 09:16:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-08 09:16:29]

Description was changed from

==========
Check the mic volume only periodically on Mac.

Ask the OS for the mic volume every 1 second rather than with every 10
ms chunk. The previous behavior was consuming ~2% of the CPU load of
a voice engine call, and is now negligible.

This is consistent with the webrtc Windows Core Audio implementation,
as well as the Chromium Mac implementation:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/agc_au...

TEST=voe_cmd_test with AGC continues to work well on Mac.
==========

to

==========
Check the mic volume only periodically on Mac.

Ask the OS for the mic volume every 1 second rather than with every 10
ms chunk. The previous behavior was consuming ~2% of the CPU load of
a voice engine call, and is now negligible.

This is consistent with the webrtc Windows Core Audio implementation,
as well as the Chromium Mac implementation:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/agc_au...

TEST=voe_cmd_test with AGC continues to work well on Mac.

Committed: https://crrev.com/ec80f03b3cd919614d82ba70837de87718e1c4a7
Cr-Commit-Position: refs/heads/master@{#11182}
==========

[commit-bot: I haz the power, 2016-01-08 09:16:31]

Patchset 1 (id:??) landed as
https://crrev.com/ec80f03b3cd919614d82ba70837de87718e1c4a7
Cr-Commit-Position: refs/heads/master@{#11182}