Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1564223002: Check the mic volume only periodically on Mac. (Closed)

Created:
3 years, 8 months ago by Andrew MacDonald
Modified:
3 years, 8 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Check the mic volume only periodically on Mac. Ask the OS for the mic volume every 1 second rather than with every 10 ms chunk. The previous behavior was consuming ~2% of the CPU load of a voice engine call, and is now negligible. This is consistent with the webrtc Windows Core Audio implementation, as well as the Chromium Mac implementation: https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/agc_audio_stream.h TEST=voe_cmd_test with AGC continues to work well on Mac. Committed: https://crrev.com/ec80f03b3cd919614d82ba70837de87718e1c4a7 Cr-Commit-Position: refs/heads/master@{#11182}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M webrtc/modules/audio_device/mac/audio_device_mac.h View 2 chunks +11 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.cc View 3 chunks +14 lines, -6 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
Andrew MacDonald
3 years, 8 months ago (2016-01-08 00:57:23 UTC) #3
henrika_webrtc
Glad to see that you are making improvements in this area Andrew ;-) LGTM https://codereview.webrtc.org/1564223002/diff/1/webrtc/modules/audio_device/mac/audio_device_mac.cc ...
3 years, 8 months ago (2016-01-08 08:14:42 UTC) #4
Andrew MacDonald
https://codereview.webrtc.org/1564223002/diff/1/webrtc/modules/audio_device/mac/audio_device_mac.cc File webrtc/modules/audio_device/mac/audio_device_mac.cc (right): https://codereview.webrtc.org/1564223002/diff/1/webrtc/modules/audio_device/mac/audio_device_mac.cc#newcode3187 webrtc/modules/audio_device/mac/audio_device_mac.cc:3187: // Use mod to ensure we check the volume ...
3 years, 8 months ago (2016-01-08 08:22:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564223002/1
3 years, 8 months ago (2016-01-08 08:22:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 8 months ago (2016-01-08 09:16:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2016-01-08 09:16:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec80f03b3cd919614d82ba70837de87718e1c4a7
Cr-Commit-Position: refs/heads/master@{#11182}

Powered by Google App Engine
This is Rietveld 408576698