Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1558733002: Update API for Objective-C RTCMediaStream. (Closed)

Created:
4 years, 11 months ago by hjon
Modified:
4 years, 11 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update API for Objective-C RTCMediaStream. BUG= R=tkchin@webrtc.org Committed: https://crrev.com/2bf9a5f11b60025a588fa58d883a191577d0e350 Patch from Jon Hjelle <hjon@andyet.net>;. Cr-Commit-Position: refs/heads/master@{#11351}

Patch Set 1 #

Patch Set 2 : Update against updated track CL #

Patch Set 3 : Update against master #

Patch Set 4 : Remove extra line #

Total comments: 12

Patch Set 5 : Changes from feedback #

Patch Set 6 : Fix build issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -10 lines) Patch
M webrtc/api/BUILD.gn View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M webrtc/api/api.gyp View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
A webrtc/api/objc/RTCMediaStream.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCMediaStream.mm View 1 2 3 4 5 1 chunk +112 lines, -0 lines 0 comments Download
A + webrtc/api/objc/RTCMediaStream+Private.h View 1 2 3 4 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
hjon
4 years, 11 months ago (2015-12-31 00:58:36 UTC) #2
tkchin_webrtc
Is this still valid?
4 years, 11 months ago (2016-01-11 22:41:10 UTC) #3
hjon
I think this is technically dependent on https://codereview.webrtc.org/1553743003, so that should get merged first and ...
4 years, 11 months ago (2016-01-11 22:50:48 UTC) #4
hjon
4 years, 11 months ago (2016-01-21 23:47:00 UTC) #5
tkchin_webrtc
https://codereview.webrtc.org/1558733002/diff/60001/webrtc/api/objc/RTCMediaStream+Private.h File webrtc/api/objc/RTCMediaStream+Private.h (right): https://codereview.webrtc.org/1558733002/diff/60001/webrtc/api/objc/RTCMediaStream+Private.h#newcode27 webrtc/api/objc/RTCMediaStream+Private.h:27: - (instancetype)initWithNativeStream: nativeMediaStream https://codereview.webrtc.org/1558733002/diff/60001/webrtc/api/objc/RTCMediaStream.mm File webrtc/api/objc/RTCMediaStream.mm (right): https://codereview.webrtc.org/1558733002/diff/60001/webrtc/api/objc/RTCMediaStream.mm#newcode22 webrtc/api/objc/RTCMediaStream.mm:22: ...
4 years, 11 months ago (2016-01-21 23:51:54 UTC) #6
hjon
https://codereview.webrtc.org/1558733002/diff/60001/webrtc/api/objc/RTCMediaStream+Private.h File webrtc/api/objc/RTCMediaStream+Private.h (right): https://codereview.webrtc.org/1558733002/diff/60001/webrtc/api/objc/RTCMediaStream+Private.h#newcode27 webrtc/api/objc/RTCMediaStream+Private.h:27: - (instancetype)initWithNativeStream: On 2016/01/21 23:51:53, tkchin_webrtc wrote: > nativeMediaStream ...
4 years, 11 months ago (2016-01-21 23:56:22 UTC) #7
tkchin_webrtc
lgtm
4 years, 11 months ago (2016-01-21 23:57:51 UTC) #8
tkchin_webrtc
Committed patchset #6 (id:100001) manually as 2bf9a5f11b60025a588fa58d883a191577d0e350 (presubmit successful).
4 years, 11 months ago (2016-01-22 00:14:29 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 00:14:31 UTC) #12
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/2bf9a5f11b60025a588fa58d883a191577d0e350
Cr-Commit-Position: refs/heads/master@{#11351}

Powered by Google App Engine
This is Rietveld 408576698