Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: webrtc/api/objc/RTCAudioTrack.mm

Issue 1553743003: Update API for Objective-C RTCAudioTrack and RTCVideoTrack. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@updateRTCMediaStreamTrack
Patch Set: Improve comments a bit Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/objc/RTCAudioTrack.mm
diff --git a/webrtc/api/objc/RTCAudioTrack.mm b/webrtc/api/objc/RTCAudioTrack.mm
new file mode 100644
index 0000000000000000000000000000000000000000..966e1267825296e96b4f2f34f10bddaaa312a388
--- /dev/null
+++ b/webrtc/api/objc/RTCAudioTrack.mm
@@ -0,0 +1,42 @@
+/*
+ * Copyright 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#import "RTCAudioTrack.h"
+
+#import "webrtc/api/objc/RTCAudioTrack+Private.h"
+#import "webrtc/api/objc/RTCMediaStreamTrack+Private.h"
+#import "webrtc/api/objc/RTCPeerConnectionFactory+Private.h"
+#import "webrtc/base/objc/NSString+StdString.h"
+
+@implementation RTCAudioTrack
+
+- (instancetype)initWithFactory:(RTCPeerConnectionFactory *)factory
+ trackId:(NSString *)trackId {
+ NSParameterAssert(factory);
+ NSParameterAssert(trackId.length);
+ std::string nativeID = [NSString stdStringForString:trackId];
+ rtc::scoped_refptr<webrtc::AudioTrackInterface> track =
+ factory.nativeFactory->CreateAudioTrack(nativeID, nullptr);
+ self =
tkchin_webrtc 2016/01/21 01:23:30 return [self initWIth...] should be enough?
hjon 2016/01/21 19:53:27 Done.
+ [self initWithNativeMediaTrack:track type:RTCMediaStreamTrackTypeAudio];
+ return self;
+}
+
+- (instancetype)initWithNativeMediaTrack:
+ (rtc::scoped_refptr<webrtc::MediaStreamTrackInterface>)nativeMediaTrack
+ type:(RTCMediaStreamTrackType)type {
+ NSParameterAssert(nativeMediaTrack);
+ NSParameterAssert(type == RTCMediaStreamTrackTypeAudio);
+ self = [super initWithNativeMediaTrack:nativeMediaTrack
tkchin_webrtc 2016/01/21 01:23:30 This should follow normal super patterns? if (sel
hjon 2016/01/21 19:53:27 I think return self = [super initWith...]; should
+ type:type];
+ return self;
+}
+
+@end

Powered by Google App Engine
This is Rietveld 408576698